Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: sky/sdk/lib/framework/net/image_cache.dart

Issue 1173703002: Move image loading out of C++ into Dart (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Rename fetchMojo to fetchUrl Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/sdk/lib/framework/net/fetch.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/framework/net/image_cache.dart
diff --git a/sky/sdk/lib/framework/net/image_cache.dart b/sky/sdk/lib/framework/net/image_cache.dart
index dcb2ac2e9d63b4eda154d832cf23b35ccd5479b7..ccd69996e022b2d5bd161788674fd8de34583bf1 100644
--- a/sky/sdk/lib/framework/net/image_cache.dart
+++ b/sky/sdk/lib/framework/net/image_cache.dart
@@ -2,17 +2,19 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-import 'dart:sky' as sky;
+import 'dart:sky';
import 'dart:collection';
+import 'fetch.dart';
+import 'package:mojom/mojo/url_response.mojom.dart';
-final HashMap<String, List<sky.ImageLoaderCallback>> _pendingRequests =
- new HashMap<String, List<sky.ImageLoaderCallback>>();
+final HashMap<String, List<ImageDecoderCallback>> _pendingRequests =
+ new HashMap<String, List<ImageDecoderCallback>>();
-final HashMap<String, sky.Image> _completedRequests =
- new HashMap<String, sky.Image>();
+final HashMap<String, Image> _completedRequests =
+ new HashMap<String, Image>();
-void load(String url, sky.ImageLoaderCallback callback) {
- sky.Image result = _completedRequests[url];
+void load(String url, ImageDecoderCallback callback) {
+ Image result = _completedRequests[url];
if (result != null) {
callback(_completedRequests[url]);
return;
@@ -21,13 +23,15 @@ void load(String url, sky.ImageLoaderCallback callback) {
bool newRequest = false;
_pendingRequests.putIfAbsent(url, () {
newRequest = true;
- return new List<sky.ImageLoaderCallback>();
+ return new List<ImageDecoderCallback>();
}).add(callback);
if (newRequest) {
- new sky.ImageLoader(url, (image) {
- _completedRequests[url] = image;
- _pendingRequests[url].forEach((c) => c(image));
- _pendingRequests.remove(url);
+ fetchUrl(url).then((UrlResponse response) {
+ new ImageDecoder(response.body.handle.h, (image) {
+ _completedRequests[url] = image;
+ _pendingRequests[url].forEach((c) => c(image));
+ _pendingRequests.remove(url);
+ });
});
}
}
« no previous file with comments | « sky/sdk/lib/framework/net/fetch.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698