Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: sky/engine/bindings/scripts/dart_methods.py

Issue 1173703002: Move image loading out of C++ into Dart (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Rename fetchMojo to fetchUrl Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/engine/bindings/scripts/dart_types.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/bindings/scripts/dart_methods.py
diff --git a/sky/engine/bindings/scripts/dart_methods.py b/sky/engine/bindings/scripts/dart_methods.py
index 3ce01527852be14a7fab423fed3e147ca09861e2..8fd541569b622b5f0eb3e7da71646260a0967bff 100644
--- a/sky/engine/bindings/scripts/dart_methods.py
+++ b/sky/engine/bindings/scripts/dart_methods.py
@@ -154,6 +154,10 @@ def cpp_value(interface, method, number_of_arguments):
if idl_type.is_typed_array_type:
return '%s.get()' % argument_name
+ # TODO(eseidel): This should check cpp_type.endswith('Handle')
+ if idl_type.name == 'MojoDataPipeConsumer':
+ return '%s.Pass()' % argument_name
+
if idl_type.name == 'EventListener':
if (interface.name == 'EventTarget' and
method.name == 'removeEventListener'):
@@ -161,9 +165,7 @@ def cpp_value(interface, method, number_of_arguments):
# EventTarget::removeEventListener
return '%s.get()' % argument_name
return argument.name
- if (idl_type.is_callback_interface or
- idl_type.name in ['NodeFilter', 'XPathNSResolver']):
- # FIXME: remove this special case
+ if idl_type.is_callback_interface:
return '%s.release()' % argument_name
return argument_name
« no previous file with comments | « no previous file | sky/engine/bindings/scripts/dart_types.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698