Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 1173703002: Move image loading out of C++ into Dart (Closed)

Created:
5 years, 6 months ago by eseidel
Modified:
5 years, 6 months ago
CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, zra
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move image loading out of C++ into Dart We already know how to talk to the network_service from Dart via fetch.dart. Might as well use that for Image loading as well insetad of having ImageLoader do it. As part of this I've renamed *ImageLoader to *ImageDecoder and moved all the image loading logic into Dart. This required me to teach the idl system about mojo handles so that I could pass the resulting MojoHandle from fetch.dart up through to ImageDecoder. R=abarth@chromium.org, jackson@google.com, hansmuller@google.com Committed: https://chromium.googlesource.com/external/mojo/+/9550a829ac7491844c78ea83987b670b9ea18ad5

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rename fetchMojo to fetchUrl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -207 lines) Patch
M sky/engine/bindings/scripts/dart_methods.py View 2 chunks +5 lines, -3 lines 0 comments Download
M sky/engine/bindings/scripts/dart_types.py View 4 chunks +7 lines, -0 lines 0 comments Download
M sky/engine/core/core.gni View 3 chunks +5 lines, -5 lines 0 comments Download
A + sky/engine/core/loader/CanvasImageDecoder.h View 1 chunk +8 lines, -17 lines 0 comments Download
A + sky/engine/core/loader/CanvasImageDecoder.cpp View 2 chunks +13 lines, -16 lines 0 comments Download
D sky/engine/core/loader/CanvasImageLoader.h View 1 chunk +0 lines, -49 lines 0 comments Download
D sky/engine/core/loader/CanvasImageLoader.cpp View 1 chunk +0 lines, -51 lines 0 comments Download
A + sky/engine/core/loader/ImageDecoder.idl View 1 chunk +3 lines, -3 lines 0 comments Download
A + sky/engine/core/loader/ImageDecoderCallback.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + sky/engine/core/loader/ImageDecoderCallback.idl View 1 chunk +1 line, -1 line 0 comments Download
D sky/engine/core/loader/ImageLoader.idl View 1 chunk +0 lines, -9 lines 0 comments Download
D sky/engine/core/loader/ImageLoaderCallback.h View 1 chunk +0 lines, -20 lines 0 comments Download
D sky/engine/core/loader/ImageLoaderCallback.idl View 1 chunk +0 lines, -7 lines 0 comments Download
M sky/engine/tonic/mojo_converter.h View 1 chunk +14 lines, -0 lines 0 comments Download
M sky/examples/stocks/lib/stock_data.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/stocks2/lib/stock_data.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/README.md View 1 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/net/fetch.dart View 1 2 chunks +17 lines, -9 lines 0 comments Download
M sky/sdk/lib/framework/net/image_cache.dart View 1 2 chunks +16 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
eseidel
5 years, 6 months ago (2015-06-09 18:25:24 UTC) #1
eseidel
mpcomplete might have commentary on the idl changes. jackson may have commentary on the image ...
5 years, 6 months ago (2015-06-09 18:26:33 UTC) #3
eseidel
Bah, was confused. Hans did the JS MojoHandle, etc, not the Dart ones, that was ...
5 years, 6 months ago (2015-06-09 18:55:49 UTC) #5
jackson
lgtm
5 years, 6 months ago (2015-06-09 19:04:53 UTC) #6
abarth-chromium
lgtm https://codereview.chromium.org/1173703002/diff/1/sky/sdk/lib/framework/net/fetch.dart File sky/sdk/lib/framework/net/fetch.dart (right): https://codereview.chromium.org/1173703002/diff/1/sky/sdk/lib/framework/net/fetch.dart#newcode24 sky/sdk/lib/framework/net/fetch.dart:24: Future<UrlResponse> fetchMojo(String relativeUrl) async { We need a ...
5 years, 6 months ago (2015-06-09 19:06:55 UTC) #7
eseidel
5 years, 6 months ago (2015-06-09 19:14:17 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9550a829ac7491844c78ea83987b670b9ea18ad5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698