Issue 11737029: Remove 'focusable' flag when there're no notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11737029: Remove 'focusable' flag when there're no notifications. (Closed)

Created:
7 years, 11 months ago by Jun Mukai

Modified:
7 years, 11 months ago

Reviewers:
miket_OOO, dharcourt

CC:
chromium-reviews, stevenjb

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove 'focusable' flag when there're no notifications. See the attachments of crbug.com/166786#c2 the bubble has border for focus. BUG=166786 TEST=open the message center bubble when there're no notifications and confirmed no focus borders appear. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175649

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	ui/message_center/message_center_bubble.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/11737029/1

7 years, 11 months ago (2013-01-07 21:56:08 UTC) #4

commit-bot: I haz the power

Retried try job too often on win_aura for step(s) interactive_ui_tests

7 years, 11 months ago (2013-01-07 23:27:20 UTC) #5

commit-bot: I haz the power

7 years, 11 months ago (2013-01-08 00:38:33 UTC) #6

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/11737029/1

Expand Messages | Collapse Messages