Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Unified Diff: chrome/browser/metrics/variations/variations_service.h

Issue 11737025: Add a switch for faking channels for Variations filtering. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: parameterize the channel Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/variations/variations_service.h
diff --git a/chrome/browser/metrics/variations/variations_service.h b/chrome/browser/metrics/variations/variations_service.h
index 5a363874deafeb12d1c1abf36b7811bc7c3052de..7a124cfbc2decaa01f7f6205fac258cb59281012 100644
--- a/chrome/browser/metrics/variations/variations_service.h
+++ b/chrome/browser/metrics/variations/variations_service.h
@@ -94,11 +94,13 @@ class VariationsService
PrefService* local_prefs);
// Returns whether |study| should be disabled according to its restriction
- // parameters. Uses |version_info| for min / max version checks and
- // |reference_date| for the start date check.
+ // parameters. Uses |version_info| for min / max version checks,
+ // |reference_date| for the start date check and |channel| for channel
+ // checks.
static bool ShouldAddStudy(const Study& study,
const chrome::VersionInfo& version_info,
- const base::Time& reference_date);
+ const base::Time& reference_date,
+ chrome::VersionInfo::Channel channel);
// Checks whether a study is applicable for the given |channel| per |filter|.
static bool CheckStudyChannel(const Study_Filter& filter,

Powered by Google App Engine
This is Rietveld 408576698