Validate that a package doesn't depend on itself.

utils/tests/pub/validator_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library validator_test;
 
 import 'dart:io';
 import 'dart:json';
 
 import 'test_pub.dart';
@@ skipping 513 matching lines @@
           ]).scheduleCreate();
 
           expectLater(schedulePackageValidation(dependency),
               pairOf(isEmpty, someElement(contains(
                   '  foo: ">=0.1.2 <0.1.3"'))));
 
           run();
         });
       });
     });
+
+    test('has a hosted dependency on itself', () {
+      dir(appPath, [
+        libPubspec("test_pkg", "1.0.0", [
+          {'hosted': 'foo'}

[Bob Nystrom, 2013/01/03 20:52:45]

Shouldn't this be "test_pkg"?

[nweiz, 2013/01/03 21:08:12]

Yes. The fact that this didn't have a version constraint caused a different
error, hence the false positive of this test. I've added a version constraint as
well.

[Bob Nystrom, 2013/01/03 21:56:17]

That makes me wonder if the expect should be more precise here so you can ensure
you get the validation warning you actually want.

[nweiz, 2013/01/03 22:18:22]

I'm not a big fan of searching for strings within error messages. I think having
validator-level granularity will be good enough most of the time.

+        ])
+      ]).scheduleCreate();
+
+      expectValidationWarning(dependency);
+
+      run();
+    });
   });
 }