Issue 1173673003: A bunch of little SkMScalar-as-float build fixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1173673003: A bunch of little SkMScalar-as-float build fixes. (Closed)

Created:
5 years, 6 months ago by mtklein_C

Modified:
5 years, 6 months ago

Reviewers:
mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

A bunch of little SkMScalar-as-float build fixes. Landing this before http://crrev.com/1169813006 so the test changes needed there are clearer. This just lets things build with floats, and is a no-op for doubles. No public API changes we didn't intend to already have... TBR=reed@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/1831f990c31bad0d84641663c96aa8eebf846ab9

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -58 lines)			Patch
M	bench/Matrix44Bench.cpp	View	4 chunks	+37 lines, -37 lines	0 comments	Download
M	include/core/SkFloatingPoint.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/utils/SkMatrix44.cpp	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	tests/Matrix44Test.cpp	View	5 chunks	+20 lines, -15 lines	0 comments	Download

Total messages: 5 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1173673003/1

5 years, 6 months ago (2015-06-09 18:40:41 UTC) #4

commit-bot: I haz the power

5 years, 6 months ago (2015-06-09 18:47:04 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1831f990c31bad0d84641663c96aa8eebf846ab9