Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: LayoutTests/fast/css-grid-layout/grid-template-shorthand-get-set.html

Issue 1173613002: [CSS Grid Layout] ASSERTION: !value || (value->isGridLineNamesValue()) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | LayoutTests/fast/css-grid-layout/grid-template-shorthand-get-set-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"> 1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
2 <html> 2 <html>
3 <head> 3 <head>
4 <link href="resources/grid.css" rel="stylesheet"> 4 <link href="resources/grid.css" rel="stylesheet">
5 <style> 5 <style>
6 #gridTemplateWithNone { 6 #gridTemplateWithNone {
7 grid-template: none; 7 grid-template: none;
8 } 8 }
9 #gridTemplateSimpleForm { 9 #gridTemplateSimpleForm {
10 grid-template: 10px / 15px; 10 grid-template: 10px / 15px;
(...skipping 27 matching lines...) Expand all
38 } 38 }
39 #gridTemplateComplexFormWithAuto { 39 #gridTemplateComplexFormWithAuto {
40 grid-template: 10px / "a"; 40 grid-template: 10px / "a";
41 } 41 }
42 #gridTemplateComplexFormOnlyAreas { 42 #gridTemplateComplexFormOnlyAreas {
43 grid-template: "a"; 43 grid-template: "a";
44 } 44 }
45 #gridTemplateNoColumnsRowWithEmptyTrailingLineNames { 45 #gridTemplateNoColumnsRowWithEmptyTrailingLineNames {
46 grid-template: [first] "a" auto []; 46 grid-template: [first] "a" auto [];
47 } 47 }
48 #gridTemplateConsecutiveAreas {
49 grid-template: 10px / "a"
50 "a";
51 }
48 52
49 /* Bad values. */ 53 /* Bad values. */
50 54
51 #gridTemplateMultipleSlash { 55 #gridTemplateMultipleSlash {
52 grid-template: 10px / 20px / 30px; 56 grid-template: 10px / 20px / 30px;
53 } 57 }
54 #gridTemplateSimpleFormJustColumns { 58 #gridTemplateSimpleFormJustColumns {
55 grid-template: 10px; 59 grid-template: 10px;
56 } 60 }
57 #gridTemplateSimpleFormNoRows { 61 #gridTemplateSimpleFormNoRows {
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 <div class="grid" id="gridTemplateComplexFormWithRepeat"></div> 152 <div class="grid" id="gridTemplateComplexFormWithRepeat"></div>
149 <div class="grid" id="gridTemplateComplexFormWithWrongRepeat"></div> 153 <div class="grid" id="gridTemplateComplexFormWithWrongRepeat"></div>
150 <div class="grid" id="griTemplateComplexFormdWithFitAvailable"></div> 154 <div class="grid" id="griTemplateComplexFormdWithFitAvailable"></div>
151 <div class="grid" id="gridTemplateComplexFormNoColumnSize"></div> 155 <div class="grid" id="gridTemplateComplexFormNoColumnSize"></div>
152 <div class="grid" id="gridTemplateComplexFormMisplacedRowsSize1"></div> 156 <div class="grid" id="gridTemplateComplexFormMisplacedRowsSize1"></div>
153 <div class="grid" id="gridTemplateComplexFormMisplacedRowsSize2"></div> 157 <div class="grid" id="gridTemplateComplexFormMisplacedRowsSize2"></div>
154 <div class="grid" id="gridTemplateComplexFormColumnsNotParsing1"></div> 158 <div class="grid" id="gridTemplateComplexFormColumnsNotParsing1"></div>
155 <div class="grid" id="gridTemplateComplexFormColumnsNotParsing2"></div> 159 <div class="grid" id="gridTemplateComplexFormColumnsNotParsing2"></div>
156 <div class="grid" id="gridTemplateComplexFormWithNoneColumns"></div> 160 <div class="grid" id="gridTemplateComplexFormWithNoneColumns"></div>
157 <div class="grid" id="gridTemplateNoColumnsRowWithTwoEmptyTrailingLineNames"></d iv> 161 <div class="grid" id="gridTemplateNoColumnsRowWithTwoEmptyTrailingLineNames"></d iv>
162 <div class="grid" id="gridTemplateConsecutiveAreas"></div>
158 <script src="resources/grid-template-shorthand-parsing-utils.js"></script> 163 <script src="resources/grid-template-shorthand-parsing-utils.js"></script>
159 <script> 164 <script>
160 description("This test checks that the 'grid-template' shorthand is properly parsed and the longhand properties correctly assigned."); 165 description("This test checks that the 'grid-template' shorthand is properly parsed and the longhand properties correctly assigned.");
161 166
162 debug("Test getting grid-template-areas set through CSS."); 167 debug("Test getting grid-template-areas set through CSS.");
163 testGridDefinitionsValues(document.getElementById("gridTemplateWithNone"), " none", "none", "none"); 168 testGridDefinitionsValues(document.getElementById("gridTemplateWithNone"), " none", "none", "none");
164 testGridDefinitionsValues(document.getElementById("gridTemplateSimpleForm"), "10px", "15px", "none"); 169 testGridDefinitionsValues(document.getElementById("gridTemplateSimpleForm"), "10px", "15px", "none");
165 testGridDefinitionsValues(document.getElementById("gridTemplateSimpleFormWit hNoneColumns"), "none", "15px", "none"); 170 testGridDefinitionsValues(document.getElementById("gridTemplateSimpleFormWit hNoneColumns"), "none", "15px", "none");
166 testGridDefinitionsValues(document.getElementById("gridTemplateSimpleFormWit hNoneRows"), "10px", "none", "none"); 171 testGridDefinitionsValues(document.getElementById("gridTemplateSimpleFormWit hNoneRows"), "10px", "none", "none");
167 testGridDefinitionsValues(document.getElementById("gridTemplateSimpleFormWit hNone"), "none", "none", "none"); 172 testGridDefinitionsValues(document.getElementById("gridTemplateSimpleFormWit hNone"), "none", "none", "none");
168 testGridDefinitionsValues(document.getElementById("gridTemplateComplexForm") , "10px", "15px", '"a"'); 173 testGridDefinitionsValues(document.getElementById("gridTemplateComplexForm") , "10px", "15px", '"a"');
169 testGridDefinitionsValues(document.getElementById("gridTemplateComplexFormWi thLineNames"), "10px", "[head] 15px [tail]", '"a"'); 174 testGridDefinitionsValues(document.getElementById("gridTemplateComplexFormWi thLineNames"), "10px", "[head] 15px [tail]", '"a"');
170 testGridDefinitionsValues(document.getElementById("gridTemplateComplexFormWi thLineNamesMultipleColumns"), "10px", "[head] 15px [tail]", '"a b"'); 175 testGridDefinitionsValues(document.getElementById("gridTemplateComplexFormWi thLineNamesMultipleColumns"), "10px", "[head] 15px [tail]", '"a b"');
171 testGridDefinitionsValues(document.getElementById("gridTemplateComplexFormWi thLineNamesMultipleRows"), "10px", "[head1] 15px [tail1 head2] 20px [tail2]", '" a" "b"'); 176 testGridDefinitionsValues(document.getElementById("gridTemplateComplexFormWi thLineNamesMultipleRows"), "10px", "[head1] 15px [tail1 head2] 20px [tail2]", '" a" "b"');
172 testGridDefinitionsValues(document.getElementById("gridTemplateComplexFormWi thLineNamesMultipleRowsAndColumns"), "[first] 10px [nav nav2] 15px [nav nav2] 15 px", "100px [nav nav2] 25px [nav nav2] 25px [last]", '"a b c" "d e f" "g h i"'); 177 testGridDefinitionsValues(document.getElementById("gridTemplateComplexFormWi thLineNamesMultipleRowsAndColumns"), "[first] 10px [nav nav2] 15px [nav nav2] 15 px", "100px [nav nav2] 25px [nav nav2] 25px [last]", '"a b c" "d e f" "g h i"');
173 testGridDefinitionsValues(document.getElementById("gridTemplateComplexFormWi thAuto"), "10px", "0px", '"a"'); 178 testGridDefinitionsValues(document.getElementById("gridTemplateComplexFormWi thAuto"), "10px", "0px", '"a"');
174 testGridDefinitionsValues(document.getElementById("gridTemplateComplexFormOn lyAreas"), "none", "0px", '"a"'); 179 testGridDefinitionsValues(document.getElementById("gridTemplateComplexFormOn lyAreas"), "none", "0px", '"a"');
175 testGridDefinitionsValues(document.getElementById("gridTemplateNoColumnsRowW ithEmptyTrailingLineNames"), "none", "[first] 0px", '"a"'); 180 testGridDefinitionsValues(document.getElementById("gridTemplateNoColumnsRowW ithEmptyTrailingLineNames"), "none", "[first] 0px", '"a"');
181 testGridDefinitionsValues(document.getElementById("gridTemplateConsecutiveAr eas"), "10px", "0px 0px", '"a" "a"');
176 182
177 debug(""); 183 debug("");
178 debug("Test getting wrong values for grid-template shorthand through CSS (th ey should resolve to the default: 'none')"); 184 debug("Test getting wrong values for grid-template shorthand through CSS (th ey should resolve to the default: 'none')");
179 testGridDefinitionsValues(document.getElementById("gridTemplateMultipleSlash "), "none", "none", "none"); 185 testGridDefinitionsValues(document.getElementById("gridTemplateMultipleSlash "), "none", "none", "none");
180 testGridDefinitionsValues(document.getElementById("gridTemplateSimpleFormJus tColumns"), "none", "none", "none"); 186 testGridDefinitionsValues(document.getElementById("gridTemplateSimpleFormJus tColumns"), "none", "none", "none");
181 testGridDefinitionsValues(document.getElementById("gridTemplateSimpleFormNoR ows"), "none", "none", "none"); 187 testGridDefinitionsValues(document.getElementById("gridTemplateSimpleFormNoR ows"), "none", "none", "none");
182 testGridDefinitionsValues(document.getElementById("gridTemplateSimpleFormNoC olumns"), "none", "none", "none"); 188 testGridDefinitionsValues(document.getElementById("gridTemplateSimpleFormNoC olumns"), "none", "none", "none");
183 testGridDefinitionsValues(document.getElementById("gridTemplateSimpleFormNoC olumnSize"), "none", "none", "none"); 189 testGridDefinitionsValues(document.getElementById("gridTemplateSimpleFormNoC olumnSize"), "none", "none", "none");
184 testGridDefinitionsValues(document.getElementById("gridTemplateSimpleFormWit hFitContent"), "none", "none", "none"); 190 testGridDefinitionsValues(document.getElementById("gridTemplateSimpleFormWit hFitContent"), "none", "none", "none");
185 testGridDefinitionsValues(document.getElementById("gridTemplateSimpleFormWit hWrongRepeat"), "none", "none", "none"); 191 testGridDefinitionsValues(document.getElementById("gridTemplateSimpleFormWit hWrongRepeat"), "none", "none", "none");
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
224 testGridDefinitionsSetBadJSValues("none / 'a'"); 230 testGridDefinitionsSetBadJSValues("none / 'a'");
225 testGridDefinitionsSetBadJSValues("25px / 'a' [name] 10px"); 231 testGridDefinitionsSetBadJSValues("25px / 'a' [name] 10px");
226 testGridDefinitionsSetBadJSValues("'a' / 'b'"); 232 testGridDefinitionsSetBadJSValues("'a' / 'b'");
227 testGridDefinitionsSetBadJSValues("15px"); 233 testGridDefinitionsSetBadJSValues("15px");
228 testGridDefinitionsSetBadJSValues("15px / 20px none"); 234 testGridDefinitionsSetBadJSValues("15px / 20px none");
229 testGridDefinitionsSetBadJSValues("25px / 10px 'a'"); 235 testGridDefinitionsSetBadJSValues("25px / 10px 'a'");
230 236
231 </script> 237 </script>
232 </body> 238 </body>
233 </html> 239 </html>
OLDNEW
« no previous file with comments | « no previous file | LayoutTests/fast/css-grid-layout/grid-template-shorthand-get-set-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698