Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1173613002: [CSS Grid Layout] ASSERTION: !value || (value->isGridLineNamesValue()) (Closed)

Created:
5 years, 6 months ago by svillar
Modified:
5 years, 6 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, jfernandez, Manuel Rego, rwlbuis, svillar
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[CSS Grid Layout] ASSERTION: !value || (value->isGridLineNamesValue()) The old Bison parser used to provide a CSSParser::ValueList with the list of idents that we'll parse as grid line names. The new one instead just provide a opening bracket followed by 1 or more idents and a closing bracket that must be parsed by the property parser. The grid-template parsing code was relying on the existence of one of those CSSParserValue::ValueList to detect invalid values for that shorthand. The problem arises whenever we try to detect whether or not the grid row specification had trailing line names or not. We can no longer look for a CSSParserValue::List in advance. Instead we take a look at the last correctly parsed element, if that's a custom indent then we can conclude that the row specification line indeed has trailing line names. BUG=497523 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196794

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M LayoutTests/fast/css-grid-layout/grid-template-shorthand-get-set.html View 3 chunks +6 lines, -0 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-template-shorthand-get-set-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
svillar
Sending for review
5 years, 6 months ago (2015-06-09 14:43:25 UTC) #2
Julien - ping for review
lgtm
5 years, 6 months ago (2015-06-09 18:28:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1173613002/1
5 years, 6 months ago (2015-06-09 18:28:26 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 19:35:16 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196794

Powered by Google App Engine
This is Rietveld 408576698