Chromium Code Reviews
Description[CSS Grid Layout] ASSERTION: !value || (value->isGridLineNamesValue())
The old Bison parser used to provide a CSSParser::ValueList with the list of
idents that we'll parse as grid line names. The new one instead just provide a
opening bracket followed by 1 or more idents and a closing bracket that must be
parsed by the property parser. The grid-template parsing code was relying on
the existence of one of those CSSParserValue::ValueList to detect invalid
values for that shorthand.
The problem arises whenever we try to detect whether or not the grid
row specification had trailing line names or not. We can no longer look for a
CSSParserValue::List in advance. Instead we take a look at the last correctly
parsed element, if that's a custom indent then we can conclude that the row
specification line indeed has trailing line names.
BUG=497523
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196794
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|
|||||||||||||||||||||||||||||||||||||