Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 1173583002: Add //content:browser dependency on //ppapi:host (Closed)

Created:
5 years, 6 months ago by Tomasz Moniuszko
Modified:
5 years, 6 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add //content:browser dependency on //ppapi:host content::BrowserPpapiHostImpl references ppapi::host::PpapiHost but dependency in missing in gn. BUG= Committed: https://crrev.com/6cddaa991266cd12f37625fd390e0d36a93e49c3 Cr-Commit-Position: refs/heads/master@{#333699}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Tomasz Moniuszko
5 years, 6 months ago (2015-06-09 11:39:56 UTC) #2
ncarter (slow)
lgtm
5 years, 6 months ago (2015-06-09 14:37:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1173583002/1
5 years, 6 months ago (2015-06-10 07:11:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-10 07:51:42 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 07:52:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6cddaa991266cd12f37625fd390e0d36a93e49c3
Cr-Commit-Position: refs/heads/master@{#333699}

Powered by Google App Engine
This is Rietveld 408576698