Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 1173543002: Non-SFI mode: Enable nacl_helper_nonsfi_unittests on bots. (Closed)

Created:
5 years, 6 months ago by hidehiko
Modified:
5 years, 6 months ago
CC:
chromium-reviews, elijahtaylor1, Junichi Uekawa, hamaji, mazda, jln (very slow on Chromium), mdempsky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Non-SFI mode: Enable nacl_helper_nonsfi_unittests on bots. This CL enables newly added nacl_helper_nonsfi_unittests on trybots. TEST=Ran bots. BUG=358465 Committed: https://crrev.com/6c1bab732320e6b71467e23e89ada492cc8400e3 Cr-Commit-Position: refs/heads/master@{#333712}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -5 lines) Patch
M components/nacl_nonsfi.gyp View 2 chunks +7 lines, -5 lines 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 5 chunks +15 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.webkit.json View 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium_arm.json View 1 chunk +2 lines, -0 lines 0 comments Download
M testing/buildbot/chromium_trybot.json View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
hidehiko
Could you take a look? mseaborn@: nacl_nonsfi.gyp phajdan.jr@, dpranke@: bot script updates. Note: some tests ...
5 years, 6 months ago (2015-06-09 18:31:41 UTC) #6
Dirk Pranke
lgtm
5 years, 6 months ago (2015-06-09 19:09:08 UTC) #7
Mark Seaborn
LGTM
5 years, 6 months ago (2015-06-10 00:09:29 UTC) #8
hidehiko
On 2015/06/10 00:09:29, Mark Seaborn wrote: > LGTM Thank you for review. Submitting.
5 years, 6 months ago (2015-06-10 09:10:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1173543002/80001
5 years, 6 months ago (2015-06-10 09:11:00 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:80001)
5 years, 6 months ago (2015-06-10 10:09:48 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 10:10:51 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c1bab732320e6b71467e23e89ada492cc8400e3
Cr-Commit-Position: refs/heads/master@{#333712}

Powered by Google App Engine
This is Rietveld 408576698