Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(62)

Issue 1173533004: Rename m_run to m_textRun in Shaper (Closed)

Created:
4 years, 10 months ago by eae
Modified:
4 years, 10 months ago
Reviewers:
szager1
CC:
blink-reviews, krit, Rik, dshwang, jbroman, Justin Novosad, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rename m_run to m_textRun in Shaper Rename the ambiguously named m_run field in Shaper and, by extension, in the sub-classes SimpleShaper and HarfBuzzShaper to m_textRun as the term run is very overloaded in the context of shaping. The name textRun makes it clear that it refers to a TextRun and not a shaping run, harfbuzz run or bidi run. This is a name only change and doesn't change any behavior. R=szager@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196884

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -50 lines) Patch
M Source/platform/fonts/shaping/HarfBuzzShaper.cpp View 21 chunks +27 lines, -27 lines 0 comments Download
M Source/platform/fonts/shaping/Shaper.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/shaping/Shaper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/shaping/SimpleShaper.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/shaping/SimpleShaper.cpp View 9 chunks +20 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
eae
4 years, 10 months ago (2015-06-10 17:42:58 UTC) #2
szager1
lgtm
4 years, 10 months ago (2015-06-10 17:49:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1173533004/1
4 years, 10 months ago (2015-06-10 17:50:40 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2015-06-10 17:53:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196884

Powered by Google App Engine
This is Rietveld 408576698