Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1266)

Unified Diff: Source/core/loader/NavigationScheduler.cpp

Issue 1173513002: Fix Blink commit type for subframes after initial about:blank load. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix broken layout test Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/loader/NavigationScheduler.cpp
diff --git a/Source/core/loader/NavigationScheduler.cpp b/Source/core/loader/NavigationScheduler.cpp
index 2ac74b8ed38c84b0d4aca49c8d1f9eb81f40c468..4b1fb07e33e8559495350402124c4404cdaac7c9 100644
--- a/Source/core/loader/NavigationScheduler.cpp
+++ b/Source/core/loader/NavigationScheduler.cpp
@@ -296,9 +296,9 @@ bool NavigationScheduler::mustLockBackForwardList(LocalFrame* targetFrame)
// "If the browsing context's session history contains only one Document,
// and that was the about:blank Document created when the browsing context
// was created, then the navigation must be done with replacement enabled."
- if (!targetFrame->loader().stateMachine()->committedMultipleRealLoads()
- && equalIgnoringCase(targetFrame->document()->url(), blankURL()))
- return true;
+ // if (!targetFrame->loader().stateMachine()->committedMultipleRealLoads()
Charlie Reis 2015/06/09 07:14:18 I'll remove this if you think this approach is san
Charlie Reis 2015/06/11 16:43:48 Done.
+ // && equalIgnoringCase(targetFrame->document()->url(), blankURL()))
+ // return true;
// Navigation of a subframe during loading of an ancestor frame does not create a new back/forward item.
// The definition of "during load" is any time before all handlers for the load event have been run.

Powered by Google App Engine
This is Rietveld 408576698