LayoutTests/http/tests/navigation/resources/forward-and-cancel-frames.html - Issue 1173513002: Fix Blink commit type for subframes after initial about:blank load.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/navigation/resources/forward-and-cancel-frames.html

Issue 1173513002: Fix Blink commit type for subframes after initial about:blank load. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix broken layout test Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!-- Parent page -->	1 <!-- Parent page -->

2 <script>	2 <script>

3 function clickLink() {	3 function clickLink() {

4 // Simulate a mouse click on a link targeting the child frame.	4 // Simulate a mouse click on a link targeting the child frame.

5 var evt = document.createEvent("MouseEvents");	5 var evt = document.createEvent("MouseEvents");

6 evt.initMouseEvent("click", true, true, window,	6 evt.initMouseEvent("click", true, true, window,

7 0, 0, 0, 0, 0, false, false, false, false, 0, null);	7 0, 0, 0, 0, 0, false, false, false, false, 0, null);

8 document.getElementById("link").dispatchEvent(evt);	8 document.getElementById("link").dispatchEvent(evt);

9 }	9 }

10 </script>	10 </script>

11 <!-- Child iframe -->	11 <!-- Child iframe -->

12 <iframe name="frame1" src="about:blank"></iframe>	12 <iframe name="frame1" src="data:text/html,initial"></iframe>
Charlie Reis 2015/06/09 07:14:18 This test (which ironically I wrote in 2011) was b This test (which ironically I wrote in 2011) was broken, since it expected to navigate from about:blank to a real page and back. The real page should replace the initial about:blank page in history, so it's not possible to go back.
13 <br>	13 <br>

14 <p>This test checks that the backForward list is not corrupted when a frame load is canceled.	14 <p>This test checks that the backForward list is not corrupted when a frame load is canceled.

15 <p>If testing manually, <a id="link" href="slow-resource.pl?delay=250" target="f rame1">click here</a> and then Back. Then click Forward and quickly click Stop. Ensure that Back and Forward still work.	15 <p>If testing manually, <a id="link" href="slow-resource.pl?delay=250" target="f rame1">click here</a> and then Back. Then click Forward and quickly click Stop. Ensure that Back and Forward still work.

OLD	NEW