Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1173503002: content: Add PERSISTENT_MAP support to IOSurface backed GpuMemoryBuffers. (Closed)

Created:
5 years, 6 months ago by reveman
Modified:
5 years, 6 months ago
Reviewers:
Daniele Castagna, piman
CC:
chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, jam, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, sievers+watch_chromium.org, danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Add PERSISTENT_MAP support to IOSurface backed GpuMemoryBuffers. BUG= TEST=content_unittests --gtest_filter=GpuMemoryBufferImplTests/GpuMemoryBufferImplTest.PersistentMap/1 Committed: https://crrev.com/58a98bb7fa71f932dc2c5fa5d2d22a9bbb9b3cee Cr-Commit-Position: refs/heads/master@{#334171}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -9 lines) Patch
M content/common/gpu/client/gpu_memory_buffer_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl_io_surface.h View 2 chunks +4 lines, -1 line 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl_io_surface.cc View 1 2 3 chunks +30 lines, -7 lines 0 comments Download
M content/common/gpu/gpu_memory_buffer_factory_io_surface.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
reveman
5 years, 6 months ago (2015-06-09 18:02:03 UTC) #2
Daniele Castagna
lgtm https://codereview.chromium.org/1173503002/diff/1/content/common/gpu/client/gpu_memory_buffer_impl_io_surface.cc File content/common/gpu/client/gpu_memory_buffer_impl_io_surface.cc (right): https://codereview.chromium.org/1173503002/diff/1/content/common/gpu/client/gpu_memory_buffer_impl_io_surface.cc#newcode64 content/common/gpu/client/gpu_memory_buffer_impl_io_surface.cc:64: DCHECK_NE(status, kIOReturnCannotLock); nit: you can log the status.
5 years, 6 months ago (2015-06-09 20:16:36 UTC) #3
Daniele Castagna
https://codereview.chromium.org/1173503002/diff/1/content/common/gpu/client/gpu_memory_buffer_impl_io_surface.cc File content/common/gpu/client/gpu_memory_buffer_impl_io_surface.cc (right): https://codereview.chromium.org/1173503002/diff/1/content/common/gpu/client/gpu_memory_buffer_impl_io_surface.cc#newcode64 content/common/gpu/client/gpu_memory_buffer_impl_io_surface.cc:64: DCHECK_NE(status, kIOReturnCannotLock); On 2015/06/09 at 20:16:36, Daniele Castagna wrote: ...
5 years, 6 months ago (2015-06-09 20:17:24 UTC) #4
reveman
+piman for content/
5 years, 6 months ago (2015-06-10 03:37:39 UTC) #6
piman
lgtm
5 years, 6 months ago (2015-06-12 00:43:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1173503002/40001
5 years, 6 months ago (2015-06-12 15:06:03 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-12 16:05:22 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 16:07:46 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/58a98bb7fa71f932dc2c5fa5d2d22a9bbb9b3cee
Cr-Commit-Position: refs/heads/master@{#334171}

Powered by Google App Engine
This is Rietveld 408576698