Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: sky/examples/lib/solid_color_box.dart

Issue 1173493003: Extend Sky's RenderFlex with intrinsic sizes and compute cross-size height (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: fix bugs Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/examples/stocks2/lib/stock_menu.dart » ('j') | sky/sdk/lib/framework/rendering/box.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/examples/lib/solid_color_box.dart
diff --git a/sky/examples/lib/solid_color_box.dart b/sky/examples/lib/solid_color_box.dart
index 9c650ce39671740aca14981eaf22de68f5bfb9ee..0a9bd38ac2f3ff6fe4f960adaa8d2bc9fe71ad75 100644
--- a/sky/examples/lib/solid_color_box.dart
+++ b/sky/examples/lib/solid_color_box.dart
@@ -14,19 +14,19 @@ class RenderSolidColorBox extends RenderDecoratedBox {
super(decoration: new BoxDecoration(backgroundColor: backgroundColor));
double getMinIntrinsicWidth(BoxConstraints constraints) {
- return constraints.constrainWidth(desiredSize.width);
+ return constraints.constrainWidth(0.0);
}
double getMaxIntrinsicWidth(BoxConstraints constraints) {
- return constraints.constrainWidth(desiredSize.width);
+ return constraints.constrainWidth(0.0);
abarth-chromium 2015/06/10 02:05:53 Why this change?
jackson 2015/06/10 04:33:39 It seemed like most users of RenderSolidColorBox w
}
double getMinIntrinsicHeight(BoxConstraints constraints) {
- return constraints.constrainHeight(desiredSize.height);
+ return constraints.constrainHeight(0.0);
}
double getMaxIntrinsicHeight(BoxConstraints constraints) {
- return constraints.constrainHeight(desiredSize.height);
+ return constraints.constrainHeight(0.0);
}
void performLayout() {
« no previous file with comments | « no previous file | sky/examples/stocks2/lib/stock_menu.dart » ('j') | sky/sdk/lib/framework/rendering/box.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698