sky/sdk/lib/framework/components2/popup_menu_item.dart - Issue 1173493003: Extend Sky's RenderFlex with intrinsic sizes and compute cross-size height

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/sdk/lib/framework/components2/popup_menu_item.dart

Issue 1173493003: Extend Sky's RenderFlex with intrinsic sizes and compute cross-size height (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: fix typos Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sky/sdk/lib/framework/components2/popup_menu_item.dart

diff --git a/sky/sdk/lib/framework/components2/popup_menu_item.dart b/sky/sdk/lib/framework/components2/popup_menu_item.dart

index bf7d64d2757df67f590b1aa10672dee972efd4f6..e78800b229594508a8967ef37079d94dbe53675b 100644

--- a/sky/sdk/lib/framework/components2/popup_menu_item.dart

+++ b/sky/sdk/lib/framework/components2/popup_menu_item.dart

@@ -16,7 +16,7 @@ class PopupMenuItem extends Component {

constraints: const BoxConstraints(minWidth: 112.0),

padding: const EdgeDims.all(16.0),

// TODO(abarth): opacity: opacity,

- child: new BlockContainer(children: children)

+ child: new FlexContainer(children: children)

);

}

« no previous file with comments | « sky/examples/stocks2/lib/stock_menu.dart ('k') | sky/sdk/lib/framework/rendering/box.dart » ('j') | no next file with comments »