Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: sky/examples/lib/solid_color_box.dart

Issue 1173493003: Extend Sky's RenderFlex with intrinsic sizes and compute cross-size height (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: fix typos Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/examples/stocks2/lib/stock_menu.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/examples/lib/solid_color_box.dart
diff --git a/sky/examples/lib/solid_color_box.dart b/sky/examples/lib/solid_color_box.dart
index 9c650ce39671740aca14981eaf22de68f5bfb9ee..bd5426a6eeba9348ac7094ca62ef1a31b1c27cae 100644
--- a/sky/examples/lib/solid_color_box.dart
+++ b/sky/examples/lib/solid_color_box.dart
@@ -14,19 +14,27 @@ class RenderSolidColorBox extends RenderDecoratedBox {
super(decoration: new BoxDecoration(backgroundColor: backgroundColor));
double getMinIntrinsicWidth(BoxConstraints constraints) {
- return constraints.constrainWidth(desiredSize.width);
+ return constraints.constrainHeight(
+ this.desiredSize == Size.infinite ? 0.0 : desiredSize.width
+ );
}
double getMaxIntrinsicWidth(BoxConstraints constraints) {
- return constraints.constrainWidth(desiredSize.width);
+ return constraints.constrainWidth(
+ this.desiredSize == Size.infinite ? 0.0 : desiredSize.width
+ );
}
double getMinIntrinsicHeight(BoxConstraints constraints) {
- return constraints.constrainHeight(desiredSize.height);
+ return constraints.constrainHeight(
+ this.desiredSize == Size.infinite ? 0.0 : desiredSize.height
+ );
}
double getMaxIntrinsicHeight(BoxConstraints constraints) {
- return constraints.constrainHeight(desiredSize.height);
+ return constraints.constrainHeight(
+ this.desiredSize == Size.infinite ? 0.0 : desiredSize.height
+ );
}
void performLayout() {
« no previous file with comments | « no previous file | sky/examples/stocks2/lib/stock_menu.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698