Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(49)

Issue 1173403006: Add webkitpy platform support for Mac 10.10 Yosemite. (Closed)

Created:
4 years, 10 months ago by joelo
Modified:
4 years, 10 months ago
Reviewers:
Dirk Pranke, jsbell, ojan
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add webkitpy platform support for Mac 10.10 Yosemite. This enables TestExpectations and rebaseline support for yosemite, and also updates the default mac version to point to the latest. BUG=496259 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197381

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -15 lines) Patch
M Tools/Scripts/webkitpy/common/system/platforminfo.py View 1 chunk +1 line, -0 lines 0 comments Download
M Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py View 1 chunk +2 lines, -1 line 2 comments Download
M Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py View 1 chunk +1 line, -1 line 1 comment Download
M Tools/Scripts/webkitpy/layout_tests/port/base.py View 2 chunks +3 lines, -2 lines 1 comment Download
M Tools/Scripts/webkitpy/layout_tests/port/builders.py View 1 chunk +1 line, -0 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/mac.py View 3 chunks +4 lines, -3 lines 1 comment Download
M Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py View 3 chunks +6 lines, -2 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py View 1 chunk +2 lines, -0 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py View 5 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
joelo
4 years, 10 months ago (2015-06-18 12:33:43 UTC) #2
ojan
lgtm https://codereview.chromium.org/1173403006/diff/1/Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py File Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py (right): https://codereview.chromium.org/1173403006/diff/1/Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py#newcode138 Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py:138: self.assertEqual(self.make_info(fake_sys('darwin'), fake_platform('10.11.0')).os_version, 'future') I don't think you should ...
4 years, 10 months ago (2015-06-18 16:27:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1173403006/1
4 years, 10 months ago (2015-06-18 16:28:31 UTC) #5
Dirk Pranke
lgtm. https://codereview.chromium.org/1173403006/diff/1/Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py File Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py (right): https://codereview.chromium.org/1173403006/diff/1/Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py#newcode138 Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py:138: self.assertEqual(self.make_info(fake_sys('darwin'), fake_platform('10.11.0')).os_version, 'future') On 2015/06/18 16:27:33, ojan wrote: ...
4 years, 10 months ago (2015-06-18 17:23:04 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2015-06-18 17:53:36 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197381

Powered by Google App Engine
This is Rietveld 408576698