content/browser/child_process_security_policy_impl.cc - Issue 11734030: Small extra validations on permission checks: reject "0" as a valid permission

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/child_process_security_policy_impl.cc

Issue 11734030: Small extra validations on permission checks: reject "0" as a valid permission (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 7 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/OWNERS ('k') | content/browser/child_process_security_policy_unittest.cc » ('j') | content/browser/child_process_security_policy_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/child_process_security_policy_impl.cc

===================================================================

--- content/browser/child_process_security_policy_impl.cc (revision 174890)

+++ content/browser/child_process_security_policy_impl.cc (working copy)

@@ -146,6 +146,8 @@

// Determine if the certain permissions have been granted to a file.

bool HasPermissionsForFile(const FilePath& file, int permissions) {

+ if (!permissions || file.empty() || !file.IsAbsolute())

+ return false;

FilePath current_path = file.StripTrailingSeparators();

FilePath last_path;

int skip = 0;