Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 11734027: Roll libjingle 254:257 (Closed)

Created:
7 years, 11 months ago by Sergey Ulanov
Modified:
7 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Roll libjingle 254:257 This roll adds device whitelist in DeviceManage, and other minor fixes. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175163

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -18 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/mock_media_stream_dependency_factory.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler_unittest.cc View 1 2 3 2 chunks +1 line, -6 lines 0 comments Download
M content/renderer/media/rtc_video_capturer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/rtc_video_capturer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/libjingle/README.chromium View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/libjingle/libjingle.gyp View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Sergey Ulanov
7 years, 11 months ago (2013-01-04 02:12:41 UTC) #1
Wez
LGTM, but can you add a sentence summarizing what the roll is for, e.g. does ...
7 years, 11 months ago (2013-01-04 02:15:40 UTC) #2
Ronghua Wu (Left Chromium)
lgtm
7 years, 11 months ago (2013-01-04 17:52:22 UTC) #3
Sergey Ulanov
+wjia for OWNERS approval in content/renderer/media
7 years, 11 months ago (2013-01-04 18:42:59 UTC) #4
xhwang
renderer/media changes lgtm
7 years, 11 months ago (2013-01-04 18:54:04 UTC) #5
wjia(left Chromium)
7 years, 11 months ago (2013-01-04 19:31:28 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698