Issue 11734022: Added simple functionality to remove interfaces from HTML lib.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11734022: Added simple functionality to remove interfaces from HTML lib. (Closed)

Created:
7 years, 11 months ago by Andrei Mouravski

Modified:
7 years, 11 months ago

Reviewers:
Emily Fortuna, blois

CC:
reviews_dartlang.org, Emily Fortuna

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Added simple functionality to remove interfaces from HTML lib. Includes one example removed interface for good measure. Committed: https://code.google.com/p/dart/source/detail?r=16929

Patch Set 1 #

Total comments: 1

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -141 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1 chunk	+0 lines, -41 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	2 chunks	+2 lines, -100 lines	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View	2 chunks	+9 lines, -0 lines	1 comment	Download
M	tools/dom/scripts/systemhtml.py	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

blois

lgtm https://codereview.chromium.org/11734022/diff/1/tools/dom/scripts/htmlrenamer.py File tools/dom/scripts/htmlrenamer.py (right): https://codereview.chromium.org/11734022/diff/1/tools/dom/scripts/htmlrenamer.py#newcode352 tools/dom/scripts/htmlrenamer.py:352: def FindInterface(self, interface): Seems like it should be ...

7 years, 11 months ago (2013-01-07 16:55:29 UTC) #3

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages