Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11734021: Roll ICU and convert include style to standard Chromium style, (Closed)

Created:
7 years, 11 months ago by Paweł Hajdan Jr.
Modified:
7 years, 11 months ago
Reviewers:
jungshik at Google
CC:
chromium-reviews, asanka, jam, sadrul, Nebojša Ćirić, nkostylev+watch_chromium.org, dhollowa+watch_chromium.org, rpetterson, ahutter, browser-components-watch_chromium.org, gideonwald, cbentzel+watch_chromium.org, Albert Bodenhamer, kinuko+watch, Ilya Sherman, yusukes+watch_chromium.org, joi+watch-content_chromium.org, melevin, ben+watch_chromium.org, benquan, stevenjb+watch_chromium.org, samarth, dbeam+watch-autofill_chromium.org, dominich, darin-cc_chromium.org, tzik+watch_chromium.org, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, dbeam+watch-options_chromium.org, rdsmith+dwatch_chromium.org, yoshiki+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, Randy Smith (Not in Mondays), penghuang+watch_chromium.org, oshima+watch_chromium.org, Raman Kakilate, Jered, tfarina, sreeram, sail+watch_chromium.org, benjhayden+dwatch_chromium.org, Aaron Boodman, David Black, Dane Wallinga, dyu1, Paweł Hajdan Jr., estade+watch_chromium.org, James Su, jshin+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Roll ICU and convert include style to standard Chromium style, i.e. third_party/... BUG=165264 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175399

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -129 lines) Patch
M DEPS View 2 chunks +2 lines, -1 line 0 comments Download
M ash/system/date/date_view.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/system/date/tray_date.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/system/power/tray_power.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/android/locale_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/bidi_line_iterator.h View 1 chunk +1 line, -2 lines 0 comments Download
M base/i18n/break_iterator.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M base/i18n/case_conversion.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/char_iterator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/i18n/file_util_icu.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/i18n/icu_encoding_detection.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/icu_string_conversions.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M base/i18n/icu_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/i18n/number_formatting.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/i18n/rtl.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M base/i18n/rtl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/string_search.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/string_search_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/time_formatting.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/autofill/autofill_country.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/autofill/autofill_regexes.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/credit_card.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/character_encoding.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/cert_library.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wallpaper_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/preferences.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system/timezone_settings.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system/timezone_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_query.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/feedback/feedback_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/snippet.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/instant/instant_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/browser_policy_connector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/signin_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/spellchecker/spelling_service_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_popup_model.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/download/download_item_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/timezone_options_util.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_l10n_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/time_format.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/renderer/pepper/ppb_pdf_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_term_feature_extractor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/spellchecker/spellcheck.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/spellchecker/spellcheck_worditerator.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_worditerator.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/common/sandbox_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/android/email_detector.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/hyphenator/hyphenator.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_main_platform_delegate_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/zygote/zygote_main_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/net_util.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M net/ftp/ftp_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/http/http_content_disposition.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/browser_font_resource_trusted.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/private/ppb_char_set_shared.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M printing/backend/print_backend.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/l10n/l10n_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/l10n/l10n_util_collator.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/l10n/l10n_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/models/table_model.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/text/text_elider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/text/text_elider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_views.cc View 2 chunks +1 line, -1 line 0 comments Download
M webkit/fileapi/file_system_dir_url_request_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webpreferences.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
7 years, 11 months ago (2013-01-03 18:58:11 UTC) #1
Paweł Hajdan Jr.
ping
7 years, 11 months ago (2013-01-07 17:14:12 UTC) #2
jungshik at Google
7 years, 11 months ago (2013-01-07 19:52:26 UTC) #3 
LGTM

@cira, FYI.

Powered by Google App Engine
This is Rietveld 408576698