Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2678)

Unified Diff: chrome/browser/extensions/options_page_apitest.cc

Issue 11734018: Revert 174880 due to compilation error in pdf_browsertest.cc (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1374/src/
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/options_page_apitest.cc
===================================================================
--- chrome/browser/extensions/options_page_apitest.cc (revision 174946)
+++ chrome/browser/extensions/options_page_apitest.cc (working copy)
@@ -16,13 +16,13 @@
using extensions::Extension;
// Used to simulate a click on the first button named 'Options'.
-static const char kScriptClickOptionButton[] =
- "(function() { "
- " var button = document.evaluate(\"//button[text()='Options']\","
- " document, null, XPathResult.UNORDERED_NODE_SNAPSHOT_TYPE,"
- " null).snapshotItem(0);"
- " button.click();"
- "})();";
+static const wchar_t* jscript_click_option_button =
+ L"(function() { "
+ L" var button = document.evaluate(\"//button[text()='Options']\","
+ L" document, null, XPathResult.UNORDERED_NODE_SNAPSHOT_TYPE,"
+ L" null).snapshotItem(0);"
+ L" button.click();"
+ L"})();";
// Test that an extension with an options page makes an 'Options' button appear
// on chrome://extensions, and that clicking the button opens a new tab with the
@@ -41,9 +41,8 @@
ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIExtensionsURL));
TabStripModel* tab_strip = browser()->tab_strip_model();
ASSERT_TRUE(content::ExecuteJavaScript(
- tab_strip->GetActiveWebContents()->GetRenderViewHost(),
- "",
- kScriptClickOptionButton));
+ tab_strip->GetActiveWebContents()->GetRenderViewHost(), L"",
+ jscript_click_option_button));
// If the options page hasn't already come up, wait for it.
if (tab_strip->count() == 1) {
« no previous file with comments | « chrome/browser/extensions/lazy_background_page_apitest.cc ('k') | chrome/browser/extensions/plugin_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698