Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5774)

Unified Diff: chrome/browser/extensions/extension_browsertest.cc

Issue 11734018: Revert 174880 due to compilation error in pdf_browsertest.cc (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1374/src/
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_browsertest.cc
===================================================================
--- chrome/browser/extensions/extension_browsertest.cc (revision 174946)
+++ chrome/browser/extensions/extension_browsertest.cc (working copy)
@@ -553,9 +553,8 @@
content::NOTIFICATION_LOAD_STOP,
content::NotificationService::AllSources());
ASSERT_TRUE(content::ExecuteJavaScript(
- contents->GetRenderViewHost(),
- "",
- "window.open('" + url.spec() + "');"));
+ contents->GetRenderViewHost(), L"",
+ L"window.open('" + UTF8ToWide(url.spec()) + L"');"));
// The above window.open call is not user-initiated, so it will create
// a popup window instead of a new tab in current window.
@@ -582,12 +581,11 @@
content::NOTIFICATION_LOAD_STOP,
content::NotificationService::AllSources());
ASSERT_TRUE(content::ExecuteJavaScriptAndExtractBool(
- contents->GetRenderViewHost(),
- "",
- "window.addEventListener('unload', function() {"
- " window.domAutomationController.send(true);"
- "}, false);"
- "window.location = '" + url.spec() + "';",
+ contents->GetRenderViewHost(), L"",
+ L"window.addEventListener('unload', function() {"
+ L" window.domAutomationController.send(true);"
+ L"}, false);"
+ L"window.location = '" + UTF8ToWide(url.spec()) + L"';",
&result));
ASSERT_TRUE(result);
observer.Wait();
« no previous file with comments | « chrome/browser/extensions/extension_bindings_apitest.cc ('k') | chrome/browser/extensions/extension_dom_clipboard_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698