Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Issue 11734018: Revert 174880 due to compilation error in pdf_browsertest.cc (Closed)

Created:
7 years, 11 months ago by dharani1
Modified:
7 years, 11 months ago
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, jam, yusukes+watch_chromium.org, tburkard+watch_chromium.org, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, gideonwald, dcheng, sreeram, Albert Bodenhamer, markusheintz_, Ilya Sherman, kinuko+watch, joi+watch-content_chromium.org, melevin, vsevik, Aaron Boodman, benjhayden+dwatch_chromium.org, samarth, dbeam+watch-autofill_chromium.org, apatrick_chromium, dominich, ajwong+watch_chromium.org, tzik+watch_chromium.org, robertshield, pedrosimonetti+watch_chromium.org, dbeam+watch-options_chromium.org, Avi (use Gerrit), jennb, creis+watch_chromium.org, rdsmith+dwatch_chromium.org, kkania, cbentzel+watch_chromium.org, jianli, penghuang+watch_chromium.org, gavinp+prer_chromium.org, pam+watch_chromium.org, chromium-apps-reviews_chromium.org, Raman Kakilate, pfeldman, Jered, Dmitry Titov, yurys, benquan, dominich+watch_chromium.org, David Black, Dane Wallinga, dyu1, darin-cc_chromium.org, estade+watch_chromium.org, James Su, mmenke
Visibility:
Public.

Description

Revert 174880 due to compilation error in pdf_browsertest.cc > Change ExecuteJavaScript* helper functions in browser_test_utils.{h,cc} > to take std::string (UTF-8) instead of std::wstring. This seems to help > simplify callsites considerably. > > TBR=jam@chromium.org > BUG=none > > > Review URL: https://chromiumcodereview.appspot.com/11728003 TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174947

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+994 lines, -1213 lines) Patch
M chrome/browser/autofill/autofill_browsertest.cc View 18 chunks +85 lines, -100 lines 0 comments Download
M chrome/browser/automation/automation_misc_browsertest.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/automation/automation_tab_helper_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_keyevents_browsertest.cc View 9 chunks +26 lines, -34 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover_browsertest.cc View 2 chunks +9 lines, -11 lines 0 comments Download
M chrome/browser/chrome_switches_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/content_settings_browsertest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/do_not_track_browsertest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/management/management_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_apitest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/extensions/app_process_apitest.cc View 6 chunks +10 lines, -14 lines 0 comments Download
M chrome/browser/extensions/chrome_app_api_browsertest.cc View 7 chunks +48 lines, -56 lines 0 comments Download
M chrome/browser/extensions/content_script_apitest.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/extensions/docs/examples/apps/calculator_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_bindings_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 2 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/extensions/extension_dom_clipboard_apitest.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_icon_source_apitest.cc View 4 chunks +8 lines, -12 lines 0 comments Download
M chrome/browser/extensions/extension_incognito_apitest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_keybinding_apitest.cc View 3 chunks +12 lines, -15 lines 0 comments Download
M chrome/browser/extensions/extension_nacl_browsertest.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_resource_request_policy_apitest.cc View 12 chunks +34 lines, -46 lines 0 comments Download
MM chrome/browser/extensions/extension_startup_browsertest.cc View 1 chunk +6 lines, -8 lines 0 comments Download
M chrome/browser/extensions/isolated_app_browsertest.cc View 7 chunks +34 lines, -35 lines 0 comments Download
M chrome/browser/extensions/lazy_background_page_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/options_page_apitest.cc View 2 chunks +9 lines, -10 lines 0 comments Download
M chrome/browser/extensions/plugin_apitest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/subscribe_page_action_browsertest.cc View 4 chunks +48 lines, -49 lines 0 comments Download
M chrome/browser/extensions/web_contents_browsertest.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/extensions/web_view_browsertest.cc View 11 chunks +63 lines, -94 lines 0 comments Download
M chrome/browser/extensions/webstore_standalone_install_browsertest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/extensions/window_open_apitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/geolocation/geolocation_browsertest.cc View 14 chunks +23 lines, -29 lines 0 comments Download
M chrome/browser/history/history_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/instant/instant_browsertest.cc View 3 chunks +12 lines, -13 lines 0 comments Download
M chrome/browser/loadtimes_extension_bindings_browsertest.cc View 3 chunks +14 lines, -21 lines 0 comments Download
M chrome/browser/net/load_timing_observer_browsertest.cc View 1 chunk +8 lines, -12 lines 0 comments Download
M chrome/browser/notifications/notification_browsertest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 4 chunks +39 lines, -39 lines 0 comments Download
M chrome/browser/policy/policy_prefs_browsertest.cc View 6 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/popup_blocker_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 7 chunks +19 lines, -27 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 13 chunks +29 lines, -47 lines 0 comments Download
M chrome/browser/tab_contents/view_source_browsertest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_focus_uitest.cc View 6 chunks +12 lines, -16 lines 0 comments Download
MM chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
MM chrome/browser/ui/panels/panel_browsertest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
MM chrome/browser/ui/webui/bookmarks_ui_browsertest.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/inspect_ui_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
MM chrome/browser/ui/webui/options/options_ui_browsertest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/preferences_browsertest.cc View 8 chunks +90 lines, -93 lines 0 comments Download
M chrome/test/base/tracing_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/test/base/ui_test_utils.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/gpu/gpu_pixel_browsertest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/bookmarklet_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_host_browsertest.cc View 34 chunks +78 lines, -70 lines 0 comments Download
M content/browser/database_browsertest.cc View 3 chunks +7 lines, -12 lines 0 comments Download
M content/browser/dom_storage/dom_storage_browsertest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/browser/encrypted_media_browsertest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/browser/fileapi/file_system_browsertest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_browsertest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_browsertest.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_view_host_manager_browsertest.cc View 33 chunks +72 lines, -106 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win_browsertest.cc View 6 chunks +12 lines, -18 lines 0 comments Download
M content/browser/session_history_browsertest.cc View 3 chunks +4 lines, -12 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webrtc_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/browser_test_utils.h View 2 chunks +8 lines, -8 lines 0 comments Download
M content/public/test/browser_test_utils.cc View 5 chunks +19 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dharani1
7 years, 11 months ago (2013-01-03 12:16:10 UTC) #1
gavinp
On 2013/01/03 12:16:10, dharani1 wrote: This is an important type of change to get right. ...
7 years, 11 months ago (2013-01-03 16:34:50 UTC) #2
gavinp
AHA, my snarky comment above is silly. I didn't look carefully enough: this was on ...
7 years, 11 months ago (2013-01-03 16:51:01 UTC) #3
gavinp
7 years, 11 months ago (2013-01-03 16:51:03 UTC) #4
Message was sent while issue was closed.
AHA, my snarky comment above is silly. I didn't look carefully enough: this was
on a branch.

Powered by Google App Engine
This is Rietveld 408576698