Issue 11734015: Fix clipboard operations through the wrench menu not working in the find bar or other controls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11734015: Fix clipboard operations through the wrench menu not working in the find bar or other controls. (Closed)

Created:
7 years, 11 months ago by jam

Modified:
7 years, 11 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina, James Su

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix clipboard operations through the wrench menu not working in the find bar or devtools. The previous approach to fix the omnibox was specific to it and that's why it didn't handle other widgets. To fix this, generalize looking for the widget by asking the FocusManager for the focused views::Textfield. I had to add a special case for devtools since the way it worked before is that it gets the synthesized keyboard shortcut and in the renderer it translates it to a clipboard operation. BUG=164235 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175409

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -60 lines)			Patch
M	chrome/browser/ui/views/frame/browser_view.h	View	1 2	1 chunk	+16 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View	1 2	3 chunks	+49 lines, -50 lines	0 comments	Download
M	chrome/browser/ui/views/omnibox/omnibox_view_views.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/omnibox/omnibox_view_views.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages

Issue 11734015: Fix clipboard operations through the wrench menu not working in the find bar or other controls. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : make work with devtools #

Messages