sync: Add ControlPreference protobuf and supporting code

sync: Add PriorityPreference protobuf and supporting code.


BUG=168648
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175874

[albertb, 2013-01-03 21:04:27]

Hi Richard,

This is the first step to supporting unencrypted, control preferences. I based
this off cr/10985008.

Albert

[rlarocque, 2013-01-03 22:40:43]

Are we sure we want to call these things Control Preferences?  It's been a
convenient name for design discussions, but I was mainly using it as a
place-holder until we could think of something better.

Here are some suggestions:
- Core User Settings
- Internal Settings
- Unencryptable Settings

Otherwise, the change looks OK.

https://codereview.chromium.org/11734009/diff/4001/chrome/browser/sync/test_p...
File chrome/browser/sync/test_profile_sync_service.cc (right):

https://codereview.chromium.org/11734009/diff/4001/chrome/browser/sync/test_p...
chrome/browser/sync/test_profile_sync_service.cc:152: // XXX
If you want to leave a TODO, please use the standard format.

ie. "// TODO(albertb): Do this later..."

https://codereview.chromium.org/11734009/diff/4001/sync/internal_api/public/b...
File sync/internal_api/public/base/model_type.h (right):

https://codereview.chromium.org/11734009/diff/4001/sync/internal_api/public/b...
sync/internal_api/public/base/model_type.h:95: // Never-encrypted control
preferences.
Could we rephrase this to make it more clear how they're distinct from
PREFERENCES?

ie. "Preferences that get applied before encryption system is initialized"?

[albertb, 2013-01-07 19:00:01]

I renamed control preferences to unencrypted preferences.

https://codereview.chromium.org/11734009/diff/4001/chrome/browser/sync/test_p...
File chrome/browser/sync/test_profile_sync_service.cc (right):

https://codereview.chromium.org/11734009/diff/4001/chrome/browser/sync/test_p...
chrome/browser/sync/test_profile_sync_service.cc:152: // XXX
On 2013/01/03 22:40:44, rlarocque wrote:
> If you want to leave a TODO, please use the standard format.
> 
> ie. "// TODO(albertb): Do this later..."

Done.

https://codereview.chromium.org/11734009/diff/4001/sync/internal_api/public/b...
File sync/internal_api/public/base/model_type.h (right):

https://codereview.chromium.org/11734009/diff/4001/sync/internal_api/public/b...
sync/internal_api/public/base/model_type.h:95: // Never-encrypted control
preferences.
On 2013/01/03 22:40:44, rlarocque wrote:
> Could we rephrase this to make it more clear how they're distinct from
> PREFERENCES?
> 
> ie. "Preferences that get applied before encryption system is initialized"?

Done.

[rlarocque, 2013-01-07 20:32:03]

I'm sorry to do this to you again, but it seems the consensus leans against
"Unencryptable Preference".  The new choice is "Priority Preference".  i.e. A
preference that has such a high priority that we would consider not showing the
UI until we have applied it.  

Could you do another search and replace for us?  I promise this will be the last
one.

[albertb, 2013-01-07 21:34:20]

On 2013/01/07 20:32:03, rlarocque wrote:
> I'm sorry to do this to you again, but it seems the consensus leans against
> "Unencryptable Preference".  The new choice is "Priority Preference".  i.e. A
> preference that has such a high priority that we would consider not showing
the
> UI until we have applied it.  
> 
> Could you do another search and replace for us?  I promise this will be the
last
> one.

Done. PTAL

[rlarocque, 2013-01-07 21:41:05]

Thanks.

Could you update the change description, too?  Everything else LGTM.

This is probably the least complicated and least controversial part of
implementing priority preferences.  You should sync up with Nicolas or myself
before starting work on the next step.

[rlarocque, 2013-01-07 21:42:08]

On 2013/01/07 21:41:05, rlarocque wrote:
> Thanks.
> 
> Could you update the change description, too?  Everything else LGTM.
> 
> This is probably the least complicated and least controversial part of
> implementing priority preferences.  You should sync up with Nicolas or myself
> before starting work on the next step.

Also, this really should be associated with a bug.

[commit-bot: I haz the power, 2013-01-08 17:27:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/albertb@chromium.org/11734009/15003

[commit-bot: I haz the power, 2013-01-08 18:32:49]

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-01-08 18:44:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/albertb@chromium.org/11734009/15003

[commit-bot: I haz the power, 2013-01-08 18:51:53]

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-01-08 18:54:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/albertb@chromium.org/11734009/29002

[commit-bot: I haz the power, 2013-01-08 18:55:14]

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-01-08 18:58:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/albertb@chromium.org/11734009/29002

[commit-bot: I haz the power, 2013-01-08 19:03:01]

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-01-08 19:07:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/albertb@chromium.org/11734009/29002

[commit-bot: I haz the power, 2013-01-08 19:10:29]

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-01-08 22:26:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/albertb@chromium.org/11734009/29002

[commit-bot: I haz the power, 2013-01-09 01:20:03]

Retried try job too often on win_rel for step(s) content_browsertests

[commit-bot: I haz the power, 2013-01-09 16:50:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/albertb@chromium.org/11734009/42001

[commit-bot: I haz the power, 2013-01-09 20:28:47]

Change committed as 175874