Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 11734004: Update ninja to v1.1.0 on Mac and Linux. (Closed)

Created:
7 years, 11 months ago by Nico
Modified:
7 years, 11 months ago
Reviewers:
tony
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org
Visibility:
Public.

Description

Update ninja to v1.1.0 on Mac, Linux32, Linux64, Windows. On mac, I ran: git checkout v1.1.0 ninja ./ninja ninja_test ./ninja_test # all passed strip ninja I verified that the empty build speed doesn't change. Mac binary size grew by ~8kB. The linux binaries were built by tony@chromium.org. The windows binary was built by scottmg@chromium.org. BUG=167996 r174818

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M ninja.exe View 1 2 Binary file 0 comments Download
M ninja-linux32 View Binary file 0 comments Download
M ninja-linux64 View Binary file 0 comments Download
M ninja-mac View Binary file 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
7 years, 11 months ago (2013-01-02 18:30:06 UTC) #1
tony
rs lgtm
7 years, 11 months ago (2013-01-02 18:31:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/11734004/9003
7 years, 11 months ago (2013-01-02 18:44:03 UTC) #3
commit-bot: I haz the power
7 years, 11 months ago (2013-01-02 18:44:05 UTC) #4
Can't process patch for file ninja-linux32.
Binary file support is temporarilly disabled due to a bug. Please commit blindly
the binary files first then commit the source change as a separate CL. Sorry for
the annoyance.

Powered by Google App Engine
This is Rietveld 408576698