Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1833)

Unified Diff: Source/devtools/front_end/network/NetworkPanel.js

Issue 1173363012: DevTools: Network panel filter bar overlaps after select resource row. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: test fixed Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/network/NetworkPanel.js
diff --git a/Source/devtools/front_end/network/NetworkPanel.js b/Source/devtools/front_end/network/NetworkPanel.js
index 6f0fddd1cb2cf47be1df4b373c5f757c94ff3e57..7ced99d3083f3abd9a18e6f0f4cffa9b2ba092fe 100644
--- a/Source/devtools/front_end/network/NetworkPanel.js
+++ b/Source/devtools/front_end/network/NetworkPanel.js
@@ -49,11 +49,8 @@ WebInspector.NetworkPanel = function()
this._filmStripRecorder = null;
this._panelToolbar = new WebInspector.Toolbar(this.element);
- this._filterBar = new WebInspector.FilterBar();
- this._filtersContainer = this.element.createChild("div", "network-filters-header hidden");
- this._filtersContainer.appendChild(this._filterBar.filtersElement());
- this._filterBar.addEventListener(WebInspector.FilterBar.Events.FiltersToggled, this._onFiltersToggled, this);
- this._filterBar.setName("networkPanel", true);
+ this._filterBar = new WebInspector.FilterBar("networkPanel", true);
+ this.element.appendChild(this._filterBar.filtersElement());
this._searchableView = new WebInspector.SearchableView(this);
this._searchableView.setPlaceholder(WebInspector.UIString("Find by filename or path"));
@@ -300,16 +297,6 @@ WebInspector.NetworkPanel.prototype = {
},
/**
- * @param {!WebInspector.Event} event
- */
- _onFiltersToggled: function(event)
- {
- var toggled = /** @type {boolean} */ (event.data);
- this._filtersContainer.classList.toggle("hidden", !toggled);
- this.doResize();
- },
-
- /**
* @override
* @return {!Array.<!Element>}
*/
« no previous file with comments | « Source/devtools/front_end/console/consoleView.css ('k') | Source/devtools/front_end/promises/PromisePane.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698