Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Unified Diff: Source/devtools/front_end/console/ConsoleView.js

Issue 1173363012: DevTools: Network panel filter bar overlaps after select resource row. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: test fixed Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/console/ConsoleView.js
diff --git a/Source/devtools/front_end/console/ConsoleView.js b/Source/devtools/front_end/console/ConsoleView.js
index 9ad214d8cb57bf4baaed5bd93d61dcdc085c9bd1..c8483ac1bf233528583fa99146395d0fa0dbae83 100644
--- a/Source/devtools/front_end/console/ConsoleView.js
+++ b/Source/devtools/front_end/console/ConsoleView.js
@@ -68,7 +68,7 @@ WebInspector.ConsoleView = function()
this._filter = new WebInspector.ConsoleViewFilter(this);
this._filter.addEventListener(WebInspector.ConsoleViewFilter.Events.FilterChanged, this._updateMessageList.bind(this));
- this._filterBar = new WebInspector.FilterBar();
+ this._filterBar = new WebInspector.FilterBar("consoleView");
this._preserveLogCheckbox = new WebInspector.ToolbarCheckbox(WebInspector.UIString("Preserve log"), WebInspector.UIString("Do not clear log on page reload / navigation."), WebInspector.moduleSetting("preserveConsoleLog"));
this._progressToolbarItem = new WebInspector.ToolbarItem(createElement("div"));
@@ -80,10 +80,7 @@ WebInspector.ConsoleView = function()
toolbar.appendToolbarItem(this._preserveLogCheckbox);
toolbar.appendToolbarItem(this._progressToolbarItem);
- this._filtersContainer = this._contentsElement.createChild("div", "console-filters-header hidden");
- this._filtersContainer.appendChild(this._filterBar.filtersElement());
- this._filterBar.addEventListener(WebInspector.FilterBar.Events.FiltersToggled, this._onFiltersToggled, this);
- this._filterBar.setName("consoleView");
+ this._contentsElement.appendChild(this._filterBar.filtersElement());
this._filter.addFilters(this._filterBar);
this._viewport = new WebInspector.ViewportControl(this);
@@ -324,12 +321,6 @@ WebInspector.ConsoleView.prototype = {
return this._promptElement;
},
- _onFiltersToggled: function(event)
- {
- var toggled = /** @type {boolean} */ (event.data);
- this._filtersContainer.classList.toggle("hidden", !toggled);
- },
-
_executionContextChanged: function()
{
this._prompt.clearAutoComplete(true);
« no previous file with comments | « LayoutTests/inspector/sources/debugger/promise-pane.html ('k') | Source/devtools/front_end/console/consoleView.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698