Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Side by Side Diff: Source/devtools/front_end/network/NetworkPanel.js

Issue 1173363012: DevTools: Network panel filter bar overlaps after select resource row. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: test fixed Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org> 3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 this._networkLogShowOverviewSetting = WebInspector.settings.createSetting("n etworkLogShowOverview", true); 42 this._networkLogShowOverviewSetting = WebInspector.settings.createSetting("n etworkLogShowOverview", true);
43 this._networkLogLargeRowsSetting = WebInspector.settings.createSetting("netw orkLogLargeRows", false); 43 this._networkLogLargeRowsSetting = WebInspector.settings.createSetting("netw orkLogLargeRows", false);
44 this._networkRecordFilmStripSetting = WebInspector.settings.createSetting("n etworkRecordFilmStripSetting", false); 44 this._networkRecordFilmStripSetting = WebInspector.settings.createSetting("n etworkRecordFilmStripSetting", false);
45 45
46 /** @type {?WebInspector.FilmStripView} */ 46 /** @type {?WebInspector.FilmStripView} */
47 this._filmStripView = null; 47 this._filmStripView = null;
48 /** @type {?WebInspector.NetworkPanel.FilmStripRecorder} */ 48 /** @type {?WebInspector.NetworkPanel.FilmStripRecorder} */
49 this._filmStripRecorder = null; 49 this._filmStripRecorder = null;
50 50
51 this._panelToolbar = new WebInspector.Toolbar(this.element); 51 this._panelToolbar = new WebInspector.Toolbar(this.element);
52 this._filterBar = new WebInspector.FilterBar(); 52 this._filterBar = new WebInspector.FilterBar("networkPanel", true);
53 this._filtersContainer = this.element.createChild("div", "network-filters-he ader hidden"); 53 this.element.appendChild(this._filterBar.filtersElement());
54 this._filtersContainer.appendChild(this._filterBar.filtersElement());
55 this._filterBar.addEventListener(WebInspector.FilterBar.Events.FiltersToggle d, this._onFiltersToggled, this);
56 this._filterBar.setName("networkPanel", true);
57 54
58 this._searchableView = new WebInspector.SearchableView(this); 55 this._searchableView = new WebInspector.SearchableView(this);
59 this._searchableView.setPlaceholder(WebInspector.UIString("Find by filename or path")); 56 this._searchableView.setPlaceholder(WebInspector.UIString("Find by filename or path"));
60 this._searchableView.show(this.element); 57 this._searchableView.show(this.element);
61 58
62 // Create top overview component. 59 // Create top overview component.
63 this._overviewPane = new WebInspector.TimelineOverviewPane("network"); 60 this._overviewPane = new WebInspector.TimelineOverviewPane("network");
64 this._overviewPane.addEventListener(WebInspector.TimelineOverviewPane.Events .WindowChanged, this._onWindowChanged.bind(this)); 61 this._overviewPane.addEventListener(WebInspector.TimelineOverviewPane.Events .WindowChanged, this._onWindowChanged.bind(this));
65 this._overviewPane.element.id = "network-overview-panel"; 62 this._overviewPane.element.id = "network-overview-panel";
66 this._networkOverview = new WebInspector.NetworkOverview(); 63 this._networkOverview = new WebInspector.NetworkOverview();
(...skipping 226 matching lines...) Expand 10 before | Expand all | Expand 10 after
293 }, 290 },
294 291
295 _dockSideChanged: function() 292 _dockSideChanged: function()
296 { 293 {
297 var detailsViewAtBottom = this._isDetailsPaneAtBottom(); 294 var detailsViewAtBottom = this._isDetailsPaneAtBottom();
298 this._splitWidget.setVertical(!detailsViewAtBottom); 295 this._splitWidget.setVertical(!detailsViewAtBottom);
299 this._updateUI(); 296 this._updateUI();
300 }, 297 },
301 298
302 /** 299 /**
303 * @param {!WebInspector.Event} event
304 */
305 _onFiltersToggled: function(event)
306 {
307 var toggled = /** @type {boolean} */ (event.data);
308 this._filtersContainer.classList.toggle("hidden", !toggled);
309 this.doResize();
310 },
311
312 /**
313 * @override 300 * @override
314 * @return {!Array.<!Element>} 301 * @return {!Array.<!Element>}
315 */ 302 */
316 elementsToRestoreScrollPositionsFor: function() 303 elementsToRestoreScrollPositionsFor: function()
317 { 304 {
318 return this._networkLogView.elementsToRestoreScrollPositionsFor(); 305 return this._networkLogView.elementsToRestoreScrollPositionsFor();
319 }, 306 },
320 307
321 /** 308 /**
322 * @override 309 * @override
(...skipping 411 matching lines...) Expand 10 before | Expand all | Expand 10 after
734 { 721 {
735 if (!this._target) 722 if (!this._target)
736 return; 723 return;
737 724
738 this._target.tracingManager.stop(); 725 this._target.tracingManager.stop();
739 this._target = null; 726 this._target = null;
740 this._callback = callback; 727 this._callback = callback;
741 this._filmStripView.setFetching(); 728 this._filmStripView.setFetching();
742 } 729 }
743 } 730 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/console/consoleView.css ('k') | Source/devtools/front_end/promises/PromisePane.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698