Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(10)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1173363012: DevTools: Network panel filter bar overlaps after select resource row. (Closed)

Created:
4 years, 10 months ago by pfeldman
Modified:
4 years, 10 months ago
Reviewers:
alph, dgozman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: Network panel filter bar overlaps after select resource row. BUG=499670 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197123

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : test fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -185 lines) Patch
M LayoutTests/inspector/sources/debugger/promise-pane.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/console/ConsoleView.js View 3 chunks +2 lines, -11 lines 0 comments Download
M Source/devtools/front_end/console/consoleView.css View 1 2 chunks +4 lines, -6 lines 0 comments Download
M Source/devtools/front_end/network/NetworkPanel.js View 2 chunks +2 lines, -15 lines 0 comments Download
M Source/devtools/front_end/promises/PromisePane.js View 8 chunks +76 lines, -121 lines 0 comments Download
M Source/devtools/front_end/promises/promisePane.css View 2 chunks +4 lines, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 4 chunks +4 lines, -14 lines 0 comments Download
M Source/devtools/front_end/ui/FilterBar.js View 3 chunks +7 lines, -16 lines 0 comments Download
M Source/devtools/front_end/ui/filter.css View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
pfeldman
4 years, 10 months ago (2015-06-12 19:41:38 UTC) #2
dgozman
Great refactoring along the way! lgtm https://codereview.chromium.org/1173363012/diff/20001/Source/devtools/front_end/ui/FilterBar.js File Source/devtools/front_end/ui/FilterBar.js (right): https://codereview.chromium.org/1173363012/diff/20001/Source/devtools/front_end/ui/FilterBar.js#newcode69 Source/devtools/front_end/ui/FilterBar.js:69: filtersElement: function() While ...
4 years, 10 months ago (2015-06-15 10:42:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1173363012/20001
4 years, 10 months ago (2015-06-15 10:54:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/66593)
4 years, 10 months ago (2015-06-15 12:16:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1173363012/40001
4 years, 10 months ago (2015-06-15 15:05:20 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2015-06-15 16:10:19 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197123

Powered by Google App Engine
This is Rietveld 408576698