Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: dm/DM.cpp

Issue 1173363011: Update DM to respect blacklists for tests (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dm/DM.cpp
diff --git a/dm/DM.cpp b/dm/DM.cpp
index 684ae8051e848f54fc9546aa00cdc7ed3ca0a237..af20a783685d7059e9e4bde58eb01da96a095854 100644
--- a/dm/DM.cpp
+++ b/dm/DM.cpp
@@ -674,9 +674,16 @@ static void run_test(skiatest::Test* test) {
}
bool verbose() const override { return FLAGS_veryVerbose; }
} reporter;
+
+ SkString note;
+ SkString whyBlacklisted = is_blacklisted("_", "tests", "_", test->name);
+ if (!whyBlacklisted.isEmpty()) {
+ note.appendf(" (--blacklist %s)", whyBlacklisted.c_str());
+ }
+
WallTimer timer;
timer.start();
- if (!FLAGS_dryRun) {
+ if (!FLAGS_dryRun && whyBlacklisted.isEmpty()) {
start("unit", "test", "", test->name);
GrContextFactory factory;
if (FLAGS_pre_log) {
@@ -685,7 +692,7 @@ static void run_test(skiatest::Test* test) {
test->proc(&reporter, &factory);
}
timer.end();
- done(timer.fWall, "unit", "test", "", test->name, "", "");
+ done(timer.fWall, "unit", "test", "", test->name, note, "");
}
/*~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~*/
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698