Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1173363009: Revert of linux: Try enabling asan for ipc_fuzzer again. (Closed)

Created:
5 years, 6 months ago by Martin Barbella
Modified:
5 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of linux: Try enabling asan for ipc_fuzzer again. (patchset #1 id:1 of https://codereview.chromium.org/1156643006/) Reason for revert: Causing timeouts on the ChromiumOS ASan Release LKGR builder. Original issue's description: > linux: Try enabling asan for ipc_fuzzer again. > > The link used to time out on Windows too but stop doing that with a recent > clang. Try if it maybe works on Linux now too. > > BUG=360158 > > Committed: https://crrev.com/32e2fafa2ce219e80097eb12b0e0885c73e61eda > Cr-Commit-Position: refs/heads/master@{#332427} TBR=glider@chromium.org,inferno@chromium.org,thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=360158 Committed: https://crrev.com/40b4153a6929a9cef7d7feddbb0901656a0bcc99 Cr-Commit-Position: refs/heads/master@{#334169}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M tools/ipc_fuzzer/fuzzer/fuzzer.gyp View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Martin Barbella
Created Revert of linux: Try enabling asan for ipc_fuzzer again.
5 years, 6 months ago (2015-06-12 15:49:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1173363009/1
5 years, 6 months ago (2015-06-12 15:49:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-12 15:51:05 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/40b4153a6929a9cef7d7feddbb0901656a0bcc99 Cr-Commit-Position: refs/heads/master@{#334169}
5 years, 6 months ago (2015-06-12 15:52:01 UTC) #4
Nico
On 2015/06/12 15:52:01, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
5 years, 6 months ago (2015-06-12 15:53:18 UTC) #5
Martin Barbella
5 years, 6 months ago (2015-06-12 15:54:06 UTC) #6
Message was sent while issue was closed.
On 2015/06/12 15:53:18, Nico (afk vacation Fri Jun 12) wrote:
> On 2015/06/12 15:52:01, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/40b4153a6929a9cef7d7feddbb0901656a0bcc99
> > Cr-Commit-Position: refs/heads/master@{#334169}
> 
> Lgtm, but should we do this only if cros==1?

Seems reasonable to me.

Powered by Google App Engine
This is Rietveld 408576698