Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1173363008: [Android] Refactor browser test execution. (RELAND) (Closed)

Created:
5 years, 6 months ago by jbudorick
Modified:
5 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jbudorick+watch_chromium.org, jochen+watch_chromium.org, klundberg+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Refactor browser test execution. (RELAND) This is a reland of https://codereview.chromium.org/1165523002/ BUG=472360 TBR=jochen@chromium.org Committed: https://crrev.com/590a3d7811a63f4be729cbbfb3ad2a0b1e2a5078 Cr-Commit-Position: refs/heads/master@{#334285}

Patch Set 1 : original #

Patch Set 2 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+599 lines, -194 lines) Patch
M base/android/java/src/org/chromium/base/Log.java View 1 4 chunks +4 lines, -0 lines 0 comments Download
M build/android/pylib/gtest/gtest_test_instance.py View 7 chunks +68 lines, -0 lines 0 comments Download
M build/android/pylib/gtest/local_device_gtest_run.py View 8 chunks +37 lines, -36 lines 0 comments Download
M build/android/pylib/gtest/setup.py View 1 chunk +2 lines, -21 lines 0 comments Download
M build/android/test_runner.py View 2 chunks +4 lines, -0 lines 0 comments Download
M build/apk_test.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 chunk +8 lines, -0 lines 0 comments Download
M build/config/android/rules.gni View 1 chunk +1 line, -0 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/test/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/test/android/browsertests_apk/AndroidManifest.xml.jinja2 View 1 chunk +2 lines, -1 line 0 comments Download
M components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsActivity.java View 2 chunks +19 lines, -39 lines 0 comments Download
M components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsApplication.java View 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 2 chunks +16 lines, -0 lines 0 comments Download
A content/shell/android/browsertests/src/org/chromium/content_shell/browsertests/ContentShellBrowserTestActivity.java View 1 chunk +89 lines, -0 lines 0 comments Download
M content/shell/android/browsertests_apk/AndroidManifest.xml.jinja2 View 1 chunk +2 lines, -1 line 0 comments Download
M content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsActivity.java View 2 chunks +19 lines, -35 lines 0 comments Download
M content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsApplication.java View 1 chunk +1 line, -1 line 0 comments Download
M testing/android/appurify_support/java/src/org/chromium/test/support/RobotiumBundleGenerator.java View 3 chunks +9 lines, -4 lines 0 comments Download
M testing/android/native_test.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M testing/android/native_test/java/src/org/chromium/native_test/NativeBrowserTestActivity.java View 2 chunks +40 lines, -1 line 0 comments Download
M testing/android/native_test/java/src/org/chromium/native_test/NativeTestActivity.java View 5 chunks +26 lines, -5 lines 0 comments Download
M testing/android/native_test/java/src/org/chromium/native_test/NativeTestInstrumentationTestRunner.java View 6 chunks +188 lines, -37 lines 0 comments Download
M testing/android/native_test/java/src/org/chromium/native_test/NativeUnitTestActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M testing/android/reporter/java/src/org/chromium/test/reporter/TestStatusReceiver.java View 1 7 chunks +29 lines, -3 lines 0 comments Download
M testing/android/reporter/java/src/org/chromium/test/reporter/TestStatusReporter.java View 3 chunks +29 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
jbudorick
The original (patch 1) broke cronet_sample_test_apk in release builds because some of the Log methods ...
5 years, 6 months ago (2015-06-12 14:49:02 UTC) #2
Ted C
lgtm
5 years, 6 months ago (2015-06-12 18:19:19 UTC) #3
cjhopman
lgtm
5 years, 6 months ago (2015-06-12 18:19:35 UTC) #4
jbudorick
+nyquist for base
5 years, 6 months ago (2015-06-12 19:23:33 UTC) #6
nyquist
base lgtm
5 years, 6 months ago (2015-06-12 22:36:53 UTC) #7
jbudorick
TBR'ing jochen for components/test/DEPS, as the change to that is the same as it was ...
5 years, 6 months ago (2015-06-12 22:59:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1173363008/20001
5 years, 6 months ago (2015-06-12 23:02:30 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-12 23:53:39 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 23:54:37 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/590a3d7811a63f4be729cbbfb3ad2a0b1e2a5078
Cr-Commit-Position: refs/heads/master@{#334285}

Powered by Google App Engine
This is Rietveld 408576698