Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 1173363004: Expose CSSGroupingRule (Closed)

Created:
5 years, 6 months ago by ramya.v
Modified:
5 years, 6 months ago
CC:
Rick Byers, blink-reviews, blink-reviews-css
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Expose CSSGroupingRule and let CSSMediaRule inherit it. Note: Inheriting CSSPageRule from CSSGroupingRule is not included in this patch as CSSPageRule does not internally represent a grouping rule as of now, since margin at-rules are yet to be implemented. BUG=496381 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197108

Patch Set 1 #

Patch Set 2 : Updating testcases #

Total comments: 2

Patch Set 3 : Updated file header and comments for CSSPageRule dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -29 lines) Patch
M LayoutTests/fast/dom/css-mediarule-functions-expected.txt View 1 1 chunk +8 lines, -8 lines 0 comments Download
M LayoutTests/platform/android/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 chunks +5 lines, -3 lines 0 comments Download
M LayoutTests/platform/android/webexposed/global-interface-listing-expected.txt View 1 2 chunks +5 lines, -3 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 chunks +5 lines, -3 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 chunks +5 lines, -3 lines 0 comments Download
M Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSGroupingRule.h View 1 chunk +1 line, -0 lines 0 comments Download
A Source/core/css/CSSGroupingRule.idl View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M Source/core/css/CSSMediaRule.idl View 1 chunk +1 line, -8 lines 0 comments Download
M Source/core/css/CSSPageRule.idl View 1 2 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
ramya.v
Modified only CSSMediaRule to inherit CSSGroupingRule. As far as CSSPageRule is concerned spec http://dev.w3.org/csswg/css-page/#at-page-rule says ...
5 years, 6 months ago (2015-06-11 14:21:49 UTC) #2
Timothy Loh
Seems fine to me but I'll defer to Philip here. By the way, please don't ...
5 years, 6 months ago (2015-06-15 07:52:15 UTC) #4
philipj_slow
Leaving CSSPageRule alone until it's actually a grouping rule internally seems best, but can you ...
5 years, 6 months ago (2015-06-15 08:15:30 UTC) #5
ramya.v
Updated as per review comments. PTAL! Thanks https://codereview.chromium.org/1173363004/diff/20001/Source/core/css/CSSGroupingRule.idl File Source/core/css/CSSGroupingRule.idl (right): https://codereview.chromium.org/1173363004/diff/20001/Source/core/css/CSSGroupingRule.idl#newcode2 Source/core/css/CSSGroupingRule.idl:2: * Copyright ...
5 years, 6 months ago (2015-06-15 08:33:19 UTC) #6
philipj_slow
This all looks good now, but the description is very minimal. Something like "Expose CSSGroupingRule ...
5 years, 6 months ago (2015-06-15 09:09:39 UTC) #7
ramya.v
On 2015/06/15 09:09:39, philipj wrote: > This all looks good now, but the description is ...
5 years, 6 months ago (2015-06-15 09:15:42 UTC) #8
philipj_slow
lgtm
5 years, 6 months ago (2015-06-15 09:25:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1173363004/40001
5 years, 6 months ago (2015-06-15 09:26:13 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-15 10:24:19 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197108

Powered by Google App Engine
This is Rietveld 408576698