Expose CSSGroupingRule

Expose CSSGroupingRule and let CSSMediaRule inherit it.

Note: Inheriting CSSPageRule from CSSGroupingRule is not 
included in this patch as CSSPageRule does not internally 
represent a grouping rule as of now, since margin at-rules 
are yet to be implemented.

BUG=496381
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197108

[ramya.v, 2015-06-11 14:21:49]

ramya.v@samsung.com changed reviewers:
+ timloh@chromium.org

[ramya.v, 2015-06-11 14:21:49]

Modified  only CSSMediaRule to inherit CSSGroupingRule.

As far as CSSPageRule is concerned spec
http://dev.w3.org/csswg/css-page/#at-page-rule says
An @page rule can also contain other at-rules, interleaved between declarations.
The current level of this specification only allows margin at-rules inside
@page.

As of now CSSMarginRule is not yet implemented.
Bug is already registered in crbug/320370 for the same.

Probably once the margin rule is implemented StyleRulePage can inherit from
StyleRuleGroup
instead of StyleRuleBase and corresponding CSSPageRule can inherit from
CSSGroupingRule. 

PTAL!


Thanks

[Timothy Loh, 2015-06-15 07:52:14]

timloh@chromium.org changed reviewers:
+ philipj@opera.com

[Timothy Loh, 2015-06-15 07:52:15]

Seems fine to me but I'll defer to Philip here.

By the way, please don't remove the automatically added cced persons and lists.

https://codereview.chromium.org/1173363004/diff/20001/Source/core/css/CSSGrou...
File Source/core/css/CSSGroupingRule.idl (right):

https://codereview.chromium.org/1173363004/diff/20001/Source/core/css/CSSGrou...
Source/core/css/CSSGroupingRule.idl:2: * Copyright (C) 2015 Samsung Electronics.
All rights reserved.
https://www.chromium.org/blink/coding-style#TOC-License

[philipj_slow, 2015-06-15 08:15:30]

Leaving CSSPageRule alone until it's actually a grouping rule internally seems
best, but can you update the TODO in CSSPageRule.idl to say what's blocking it
and link to that bug?

[ramya.v, 2015-06-15 08:33:19]

Updated as per review comments. PTAL!

Thanks

https://codereview.chromium.org/1173363004/diff/20001/Source/core/css/CSSGrou...
File Source/core/css/CSSGroupingRule.idl (right):

https://codereview.chromium.org/1173363004/diff/20001/Source/core/css/CSSGrou...
Source/core/css/CSSGroupingRule.idl:2: * Copyright (C) 2015 Samsung Electronics.
All rights reserved.
On 2015/06/15 07:52:15, Timothy Loh wrote:
> https://www.chromium.org/blink/coding-style#TOC-License

Done.

[philipj_slow, 2015-06-15 09:09:39]

This all looks good now, but the description is very minimal. Something like
"Expose CSSGroupingRule and let CSSMediaRule inherit it" together with a note
that CSSPageRule is not included would be good.

[ramya.v, 2015-06-15 09:15:42]

On 2015/06/15 09:09:39, philipj wrote:
> This all looks good now, but the description is very minimal. Something like
> "Expose CSSGroupingRule and let CSSMediaRule inherit it" together with a note
> that CSSPageRule is not included would be good.


Updated the description. PTAL!

[philipj_slow, 2015-06-15 09:25:54]

The CQ bit was checked by philipj@opera.com

[philipj_slow, 2015-06-15 09:25:55]

lgtm

[commit-bot: I haz the power, 2015-06-15 09:26:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1173363004/40001

[commit-bot: I haz the power, 2015-06-15 10:24:19]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197108