components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h - Issue 1173343009: LevelDB storage for data reduction proxy to store data usage stats.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h

Issue 1173343009: LevelDB storage for data reduction proxy to store data usage stats. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove friend from impl Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.h ('K') | « components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_service.cc » ('j') | components/data_reduction_proxy/core/browser/data_usage_storage_helper.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h

index 9474cf996156ffeb0fdd0beb6c6682d72fe464b2..99bb75645f34b4b0370ab25a05e5f4974c749a10 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h

@@ -14,7 +14,7 @@

#include "base/memory/scoped_ptr.h"

#include "base/memory/weak_ptr.h"

#include "base/observer_list.h"

-#include "base/single_thread_task_runner.h"

+#include "base/sequenced_task_runner.h"

#include "base/threading/non_thread_safe.h"

#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics.h"

#include "components/data_reduction_proxy/core/common/data_reduction_proxy_event_storage_delegate.h"

@@ -70,11 +70,13 @@ class DataReductionProxyService

// final step in initialization.

bool Initialized() const;

- // Constructs compression stats. This should not be called if a valid

- // compression stats is passed into the constructor.

+ // Constructs compression stats with a dummy store which does nothing. Load

jeremyim 2015/06/30 01:59:18 Constructs compression stats with a noop |DataRedu

Not at Google. Contact bengr 2015/07/01 17:13:49 Done.

+ // and store calls to this store are no-ops. This should not be called

+ // if a valid compression stats is passed into the constructor.

void EnableCompressionStatisticsLogging(

PrefService* prefs,

scoped_refptr<base::SequencedTaskRunner> ui_task_runner,

+ scoped_refptr<base::SequencedTaskRunner> db_task_runner,

const base::TimeDelta& commit_delay);

// Records daily data savings statistics in |compression_stats_|.