components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h - Issue 1173343009: LevelDB storage for data reduction proxy to store data usage stats.

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h

Issue 1173343009: LevelDB storage for data reduction proxy to store data usage stats. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use raw pointers for arguments instead of ref counting Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc ('K') | « components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_service.cc » ('j') | components/data_reduction_proxy/core/browser/data_reduction_proxy_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h

index 9474cf996156ffeb0fdd0beb6c6682d72fe464b2..476d1a4bce3d6c93526266cfa1e43c7da93c8370 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h

@@ -70,11 +70,12 @@ class DataReductionProxyService

// final step in initialization.

bool Initialized() const;

- // Constructs compression stats. This should not be called if a valid

- // compression stats is passed into the constructor.

+ // Constructs compression stats with a dummy store. This should not be called

bengr 2015/06/25 23:22:54 What is a dummy store?

Not at Google. Contact bengr 2015/06/29 20:53:27 Done.

+ // if a valid compression stats is passed into the constructor.

void EnableCompressionStatisticsLogging(

PrefService* prefs,

- scoped_refptr<base::SequencedTaskRunner> ui_task_runner,

+ scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner,

+ scoped_refptr<base::SingleThreadTaskRunner> db_task_runner,

michaeln 2015/06/26 20:15:01 We have a preference for using the SequencedWorker

Not at Google. Contact bengr 2015/06/29 20:53:27 Reverted back to using SequencedTaskRunner. This c

const base::TimeDelta& commit_delay);

// Records daily data savings statistics in |compression_stats_|.