components/data_reduction_proxy/core/browser/DEPS - Issue 1173343009: LevelDB storage for data reduction proxy to store data usage stats.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/data_reduction_proxy/core/browser/DEPS

Issue 1173343009: LevelDB storage for data reduction proxy to store data usage stats. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add missing include Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/BUILD.gn ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_store.h » ('j') | components/data_reduction_proxy/core/browser/data_reduction_proxy_store_impl.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+third_party/leveldatabase",	2 "+third_party/leveldatabase",

	3 "+content/public/browser/browser_thread.h",
	jeremyim 2015/07/01 21:31:01 I believe this is a layering violation. I believe this is a layering violation. Not at Google. Contact bengr 2015/07/01 23:17:37 Good point. Fixed. Show quoted text On 2015/07/01 21:31:01, jeremyim wrote: > I believe this is a layering violation. Good point. Fixed.
3 ]	4 ]

OLD	NEW