Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Side by Side Diff: src/arm/simulator-arm.cc

Issue 1173343006: Replace OFFSET_OF with offsetof as far as possible. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixed typing chaos on ARM. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm64/simulator-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stdarg.h> 5 #include <stdarg.h>
6 #include <stdlib.h> 6 #include <stdlib.h>
7 #include <cmath> 7 #include <cmath>
8 8
9 #include "src/v8.h" 9 #include "src/v8.h"
10 10
(...skipping 805 matching lines...) Expand 10 before | Expand all | Expand 10 after
816 DCHECK_EQ(current->type(), type); 816 DCHECK_EQ(current->type(), type);
817 return current; 817 return current;
818 } 818 }
819 } 819 }
820 return new Redirection(external_function, type); 820 return new Redirection(external_function, type);
821 } 821 }
822 822
823 static Redirection* FromSwiInstruction(Instruction* swi_instruction) { 823 static Redirection* FromSwiInstruction(Instruction* swi_instruction) {
824 char* addr_of_swi = reinterpret_cast<char*>(swi_instruction); 824 char* addr_of_swi = reinterpret_cast<char*>(swi_instruction);
825 char* addr_of_redirection = 825 char* addr_of_redirection =
826 addr_of_swi - OFFSET_OF(Redirection, swi_instruction_); 826 addr_of_swi - offsetof(Redirection, swi_instruction_);
827 return reinterpret_cast<Redirection*>(addr_of_redirection); 827 return reinterpret_cast<Redirection*>(addr_of_redirection);
828 } 828 }
829 829
830 static void* ReverseRedirection(int32_t reg) { 830 static void* ReverseRedirection(int32_t reg) {
831 Redirection* redirection = FromSwiInstruction( 831 Redirection* redirection = FromSwiInstruction(
832 reinterpret_cast<Instruction*>(reinterpret_cast<void*>(reg))); 832 reinterpret_cast<Instruction*>(reinterpret_cast<void*>(reg)));
833 return redirection->external_function(); 833 return redirection->external_function();
834 } 834 }
835 835
836 static void DeleteChain(Redirection* redirection) { 836 static void DeleteChain(Redirection* redirection) {
(...skipping 3313 matching lines...) Expand 10 before | Expand all | Expand 10 after
4150 set_register(sp, current_sp + sizeof(uintptr_t)); 4150 set_register(sp, current_sp + sizeof(uintptr_t));
4151 return address; 4151 return address;
4152 } 4152 }
4153 4153
4154 } // namespace internal 4154 } // namespace internal
4155 } // namespace v8 4155 } // namespace v8
4156 4156
4157 #endif // USE_SIMULATOR 4157 #endif // USE_SIMULATOR
4158 4158
4159 #endif // V8_TARGET_ARCH_ARM 4159 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm64/simulator-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698