Refactor some Timeline interfaces to be simpler and support streaming

runtime/vm/dart_api_impl_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/builtin.h"
 #include "include/dart_api.h"
 #include "include/dart_debugger_api.h"
 #include "include/dart_mirrors_api.h"
 #include "include/dart_native_api.h"
 #include "platform/assert.h"
@@ skipping 9145 matching lines @@
 
 TEST_CASE(Timeline_Dart_TimelineDuration) {
   Isolate* isolate = Isolate::Current();
   // Grab embedder stream.
   TimelineStream* stream = isolate->GetEmbedderStream();
   // Make sure it is enabled.
   stream->set_enabled(true);
   // Add a duration event.
   Dart_TimelineDuration("testDurationEvent", 0, 1);
   // Check that it is in the output.
-  TimelineEventBuffer* buffer = isolate->timeline_event_buffer();
+  TimelineEventRecorder* recorder = isolate->timeline_event_recorder();
   JSONStream js;
-  buffer->PrintJSON(&js);
+  recorder->PrintJSON(&js);
   EXPECT_SUBSTRING("testDurationEvent", js.ToCString());
 }
 
 
 TEST_CASE(Timeline_Dart_TimelineInstant) {
   Isolate* isolate = Isolate::Current();
   // Grab embedder stream.
   TimelineStream* stream = isolate->GetEmbedderStream();
   // Make sure it is enabled.
   stream->set_enabled(true);
   Dart_TimelineInstant("testInstantEvent");
   // Check that it is in the output.
-  TimelineEventBuffer* buffer = isolate->timeline_event_buffer();
+  TimelineEventRecorder* recorder = isolate->timeline_event_recorder();
   JSONStream js;
-  buffer->PrintJSON(&js);
+  recorder->PrintJSON(&js);
   EXPECT_SUBSTRING("testInstantEvent", js.ToCString());
 }
 
 
 TEST_CASE(Timeline_Dart_TimelineAsyncDisabled) {
   Isolate* isolate = Isolate::Current();
   // Grab embedder stream.
   TimelineStream* stream = isolate->GetEmbedderStream();
   // Make sure it is disabled.
   stream->set_enabled(false);
   int64_t async_id = -1;
   Dart_TimelineAsyncBegin("testAsyncEvent", &async_id);
   // Expect that the |async_id| is negative because the stream is disabled.
   EXPECT(async_id < 0);
   // Call Dart_TimelineAsyncEnd with a negative async_id.
   Dart_TimelineAsyncEnd("testAsyncEvent", async_id);
   // Check that testAsync is not in the output.
-  TimelineEventBuffer* buffer = isolate->timeline_event_buffer();
+  TimelineEventRecorder* recorder = isolate->timeline_event_recorder();
   JSONStream js;
-  buffer->PrintJSON(&js);
+  recorder->PrintJSON(&js);
   EXPECT_NOTSUBSTRING("testAsyncEvent", js.ToCString());
 }
 
 
 TEST_CASE(Timeline_Dart_TimelineAsync) {
   Isolate* isolate = Isolate::Current();
   // Grab embedder stream.
   TimelineStream* stream = isolate->GetEmbedderStream();
   // Make sure it is enabled.
   stream->set_enabled(true);
   int64_t async_id = -1;
   Dart_TimelineAsyncBegin("testAsyncEvent", &async_id);
   // Expect that the |async_id| is >= 0.
   EXPECT(async_id >= 0);
 
   Dart_TimelineAsyncEnd("testAsyncEvent", async_id);
 
   // Check that it is in the output.
-  TimelineEventBuffer* buffer = isolate->timeline_event_buffer();
+  TimelineEventRecorder* recorder = isolate->timeline_event_recorder();
   JSONStream js;
-  buffer->PrintJSON(&js);
+  recorder->PrintJSON(&js);
   EXPECT_SUBSTRING("testAsyncEvent", js.ToCString());
 }
 
 }  // namespace dart