Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 1173333003: GC plugin: enable plugin on anonymous namespaces. (Closed)

Created:
5 years, 6 months ago by sof
Modified:
5 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GC plugin: enable plugin on anonymous namespaces. R=haraken BUG=499738 Committed: https://crrev.com/b567a5775e63641d64dd10bf4ebe6f652b5e7743 Cr-Commit-Position: refs/heads/master@{#334141}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/tests/stack_allocated.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/stack_allocated.txt View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
please take a look. Retired the use of "WebKit" at the same time; no longer ...
5 years, 6 months ago (2015-06-12 10:01:08 UTC) #2
haraken
LGTM
5 years, 6 months ago (2015-06-12 10:03:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1173333003/1
5 years, 6 months ago (2015-06-12 10:33:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-12 10:41:32 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 10:42:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b567a5775e63641d64dd10bf4ebe6f652b5e7743
Cr-Commit-Position: refs/heads/master@{#334141}

Powered by Google App Engine
This is Rietveld 408576698