Silence warning about falling back to checked-in adb binary

Silence warning about falling back to checked-in adb binary

There's no need to print out a warning about falling back to the
checked-in adb binary every time telemetry is run. Also turn ADB_PATH
into a memoized function to remove side effects from importing
constants.py. This also ensures the right logging level is set before
the path is determined so the warning is still printed in debug mode.

BUG=329317
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241854

[frankf, 2013-12-18 18:30:27]

lgtm

https://codereview.chromium.org/117333008/diff/1/build/android/pylib/constant...
File build/android/pylib/constants.py (right):

https://codereview.chromium.org/117333008/diff/1/build/android/pylib/constant...
build/android/pylib/constants.py:17: return func._result
just curious: why not use hasattr instead of try/except?

Also, move this down just before the method using it.

[Sami, 2013-12-18 18:54:14]

On 2013/12/18 18:30:27, frankf wrote:
> lgtm
> 
>
https://codereview.chromium.org/117333008/diff/1/build/android/pylib/constant...
> File build/android/pylib/constants.py (right):
> 
>
https://codereview.chromium.org/117333008/diff/1/build/android/pylib/constant...
> build/android/pylib/constants.py:17: return func._result
> just curious: why not use hasattr instead of try/except?

Just as a hint to the runtime (and the reader of the code) that having the
attribute there will be the expected case. I suppose it doesn't really make a
difference in practice though.

> Also, move this down just before the method using it.

Done.

[commit-bot: I haz the power, 2013-12-18 18:56:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skyostil@chromium.org/117333008/20001

[commit-bot: I haz the power, 2013-12-18 23:00:48]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-12-19 10:52:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skyostil@chromium.org/117333008/20001

[commit-bot: I haz the power, 2013-12-19 13:53:48]

Change committed as 241854