Adjust aura synthetic mouse event locations to screen location.

Adjust aura synthetic mouse event locations to screen location.

This is an attempt to fix flaky page scroll unittests in win aura.

BUG=328970
BUG=323249
BUG=297960
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242062

[kouhei (in TOK), 2013-12-18 03:56:30]

sadrul, dominikg: Would you take a look?

[Dominik Grewe, 2013-12-18 10:33:53]

Thanks Kouhei.

https://codereview.chromium.org/117333006/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/input/synthetic_gesture_target_aura.cc
(right):

https://codereview.chromium.org/117333006/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/input/synthetic_gesture_target_aura.cc:134:
position_client->ConvertPointToScreen(window, &location);
I guess we should do the same for mouse wheel events.

Since we now do this conversion in each of the dispatch functions, do you want
to extract this into a helper function? Maybe one that returns
ScreenPositionClient*?

[kouhei (in TOK), 2013-12-19 04:55:39]

PTAL. I confirmed that "tools/telemetry/run_tests --browser=debug
ScrollActionTest.testScrollAction" reliably passes on my local machine.

https://codereview.chromium.org/117333006/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/input/synthetic_gesture_target_aura.cc
(right):

https://codereview.chromium.org/117333006/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/input/synthetic_gesture_target_aura.cc:134:
position_client->ConvertPointToScreen(window, &location);
On 2013/12/18 10:33:53, Dominik Grewe wrote:
> I guess we should do the same for mouse wheel events.
> 
> Since we now do this conversion in each of the dispatch functions, do you want
> to extract this into a helper function? Maybe one that returns
> ScreenPositionClient*?

Done.

[sadrul, 2013-12-19 05:02:53]

lgtm

[Dominik Grewe, 2013-12-19 16:45:37]

LGTM. Thanks Kouhei!

On 2013/12/19 04:55:39, kouhei wrote:
> PTAL. I confirmed that "tools/telemetry/run_tests --browser=debug
> ScrollActionTest.testScrollAction" reliably passes on my local machine.

Is this a Windows machine and are you using an Aura build? The problems only
seem to occur with this particular combination.

[commit-bot: I haz the power, 2013-12-19 19:08:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kouhei@chromium.org/117333006/20001

[kouhei (in TOK), 2013-12-19 19:09:28]

Thanks for review!

> On 2013/12/19 04:55:39, kouhei wrote:
> > PTAL. I confirmed that "tools/telemetry/run_tests --browser=debug
> > ScrollActionTest.testScrollAction" reliably passes on my local machine.
> 
> Is this a Windows machine and are you using an Aura build? The problems only
> seem to occur with this particular combination.

No, I don't have a Windows machine atm.

[commit-bot: I haz the power, 2013-12-20 00:40:27]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-12-20 01:35:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kouhei@chromium.org/117333006/20001

[commit-bot: I haz the power, 2013-12-20 08:59:47]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-12-20 09:23:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kouhei@chromium.org/117333006/20001

[commit-bot: I haz the power, 2013-12-20 11:02:49]

Change committed as 242062