Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 1173313003: Correct fast/multicol/vertical-rl/image-inside-nested-blocks-with-border.html (Closed)

Created:
5 years, 6 months ago by mstensho (USE GERRIT)
Modified:
5 years, 6 months ago
Reviewers:
dsinclair
CC:
blink-reviews, mstensho (USE GERRIT)
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Correct fast/multicol/vertical-rl/image-inside-nested-blocks-with-border.html We have a float at the beginning of the second column. The test wanted the float to have its left edge flush with the left edge of the multicol container, but this is vertical-rl writing mode, so it will instead have its right edge flush with the right edge of the multicol container, since that's where columns start in the block progression direction. So the test "failed" and was stored as such in the expectation file. But both the layout engine and the behavior of getBoundingClientRect were correct all along. Corrected the test, and removed a bunch of boilerplate and turned it into something using js-test.js instead. In order to be consistent, I also cleaned up the vertical-lr and horiontal-tb (default) variants in the same way as well. R=dsinclair@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197040

Patch Set 1 #

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
5 years, 6 months ago (2015-06-12 13:58:32 UTC) #1
dsinclair
lgtm
5 years, 6 months ago (2015-06-12 15:08:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1173313003/1
5 years, 6 months ago (2015-06-12 15:09:18 UTC) #4
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 15:13:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197040

Powered by Google App Engine
This is Rietveld 408576698