Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 11733008: Revert 175782 (Closed)

Created:
7 years, 11 months ago by sullivan
Modified:
7 years, 11 months ago
Reviewers:
nduca
CC:
chromium-reviews, chrome-speed-team+watch_google.com, pam+watch_chromium.org, telemetry+watch_chromium.org
Visibility:
Public.

Description

Revert 175782 > InspectorTimeline improvements > > - Split out inspector-neutral parts of InspectorTimeline in preparation for > about:tracing-based timeline > - Use event.name instead of type, which is in keeping with trace-viewer > - Use ms on units since the rest of telemetry uses seconds, but > for precision reasons, ms makes sense to stick with > - Move arguments to event.args so that params get consistent treatment > e.g. event.foo['bar'] is less consistent than event.args['foo']['bar'] > - Improved test coverage of model, events, parsing > - event.self_time which represents > - drop events lacking start- or end- times > > R=bulach@chromium.org > NOTRY=True > > Review URL: https://chromiumcodereview.appspot.com/11818024 TBR=nduca@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175810

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -275 lines) Patch
M tools/perf/perf_tools/image_decoding_benchmark.py View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/inspector_timeline.py View 4 chunks +46 lines, -64 lines 0 comments Download
M tools/telemetry/telemetry/inspector_timeline_unittest.py View 3 chunks +52 lines, -91 lines 0 comments Download
D tools/telemetry/telemetry/timeline_event.py View 1 chunk +0 lines, -48 lines 0 comments Download
D tools/telemetry/telemetry/timeline_event_unittest.py View 1 chunk +0 lines, -27 lines 0 comments Download
D tools/telemetry/telemetry/timeline_model.py View 1 chunk +0 lines, -23 lines 0 comments Download
D tools/telemetry/telemetry/timeline_model_unittest.py View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
sullivan
7 years, 11 months ago (2013-01-09 16:39:12 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698