Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: chrome/installer/util/util_constants.cc

Issue 11733007: Duplicate setup.exe into an identical executable and point Active Setup to that executable instead. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: chromesu.exe Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/util_constants.cc
diff --git a/chrome/installer/util/util_constants.cc b/chrome/installer/util/util_constants.cc
index 47c3605929bde05ce1befcf943da555c28163002..d9bedd3050c921a67781f41bc7a305b3a05085d2 100644
--- a/chrome/installer/util/util_constants.cc
+++ b/chrome/installer/util/util_constants.cc
@@ -193,6 +193,16 @@ const char kToastResultsKey[] = "toast-results-key";
} // namespace switches
+// The Active Setup executable will be an identical copy of setup.exe; this is
+// necessary because Windows' installer detection heuristics (which include
+// things like process name being "setup.exe") will otherwise force elevation
+// for non-admin users when setup.exe is launched. This is mitigated by adding
+// requestedExecutionLevel="asInvoker" to setup.exe's manifest on Vista+, but
+// there is no such manifest entry on Windows XP (which results in
+// crbug.com/166473).
+// TODO(gab): Rename setup.exe itself altogether and use the same binary for
+// Active Setup.
+const wchar_t kActiveSetupExe[] = L"chromesu.exe";
robertshield 2013/01/09 15:51:59 <bikeshed>That reads quickly as "chrome sux", cons
gab 2013/01/09 18:47:52 Ok what about chrmstp.exe (i.e. chromesetup with n
robertshield 2013/01/09 18:53:14 SGTM :)
const wchar_t kChromeAppHostExe[] = L"app_host.exe";
const wchar_t kChromeDll[] = L"chrome.dll";
const wchar_t kChromeExe[] = L"chrome.exe";
« chrome/installer/setup/install_worker.h ('K') | « chrome/installer/util/util_constants.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698