Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: chrome/installer/util/util_constants.cc

Issue 11733007: Duplicate setup.exe into an identical executable and point Active Setup to that executable instead. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/installer/util/util_constants.h" 5 #include "chrome/installer/util/util_constants.h"
6 6
7 namespace installer { 7 namespace installer {
8 8
9 namespace switches { 9 namespace switches {
10 10
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
186 186
187 // The group this experiment belongs to. 187 // The group this experiment belongs to.
188 const char kExperimentGroup[] = "experiment-group"; 188 const char kExperimentGroup[] = "experiment-group";
189 189
190 // A handle value of the key to write the results of the toast experiment 190 // A handle value of the key to write the results of the toast experiment
191 // to. See DuplicateGoogleUpdateSystemClientKey for details. 191 // to. See DuplicateGoogleUpdateSystemClientKey for details.
192 const char kToastResultsKey[] = "toast-results-key"; 192 const char kToastResultsKey[] = "toast-results-key";
193 193
194 } // namespace switches 194 } // namespace switches
195 195
196 // The Active Setup executable will be an identical copy of setup.exe; this is
197 // necessary because Windows' installer detection heuristics (which include
198 // things like process name being "setup.exe") will otherwise force elevation
199 // for non-admin users when setup.exe is launched. This is mitigated by adding
200 // requestedExecutionLevel="asInvoker" to setup.exe's manifest on Vista+, but
201 // there is no such manifest entry on Windows XP (which results in
202 // crbug.com/166473). The name "as.exe" is short and obscur on purpose so that:
203 // 1) It is not detected as an installer by any naming-based heuristic.
204 // 2) No adventurous user feels like running this will solve his problems (as
205 // something like "user_config.exe" could otherwise suggest).
206 // TODO(gab): Rename setup.exe itself altogether and use the same binary for
207 // Active Setup.
208 const wchar_t kActiveSetupExe[] = L"as.exe";
grt (UTC plus 2) 2013/01/09 14:13:15 This name is too short and obscure. How about usin
gab 2013/01/09 15:39:42 sgtm :)!
196 const wchar_t kChromeAppHostExe[] = L"app_host.exe"; 209 const wchar_t kChromeAppHostExe[] = L"app_host.exe";
197 const wchar_t kChromeDll[] = L"chrome.dll"; 210 const wchar_t kChromeDll[] = L"chrome.dll";
198 const wchar_t kChromeExe[] = L"chrome.exe"; 211 const wchar_t kChromeExe[] = L"chrome.exe";
199 const wchar_t kChromeFrameDll[] = L"npchrome_frame.dll"; 212 const wchar_t kChromeFrameDll[] = L"npchrome_frame.dll";
200 const wchar_t kChromeFrameHelperExe[] = L"chrome_frame_helper.exe"; 213 const wchar_t kChromeFrameHelperExe[] = L"chrome_frame_helper.exe";
201 const wchar_t kChromeFrameHelperWndClass[] = L"ChromeFrameHelperWindowClass"; 214 const wchar_t kChromeFrameHelperWndClass[] = L"ChromeFrameHelperWindowClass";
202 const wchar_t kChromeFrameReadyModeField[] = L"ChromeFrameReadyMode"; 215 const wchar_t kChromeFrameReadyModeField[] = L"ChromeFrameReadyMode";
203 const wchar_t kChromeLauncherExe[] = L"chrome_launcher.exe"; 216 const wchar_t kChromeLauncherExe[] = L"chrome_launcher.exe";
204 const wchar_t kChromeNewExe[] = L"new_chrome.exe"; 217 const wchar_t kChromeNewExe[] = L"new_chrome.exe";
205 const wchar_t kChromeOldExe[] = L"old_chrome.exe"; 218 const wchar_t kChromeOldExe[] = L"old_chrome.exe";
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
244 // Chrome channel display names. 257 // Chrome channel display names.
245 const wchar_t kChromeChannelUnknown[] = L"unknown"; 258 const wchar_t kChromeChannelUnknown[] = L"unknown";
246 const wchar_t kChromeChannelCanary[] = L"canary"; 259 const wchar_t kChromeChannelCanary[] = L"canary";
247 const wchar_t kChromeChannelDev[] = L"dev"; 260 const wchar_t kChromeChannelDev[] = L"dev";
248 const wchar_t kChromeChannelBeta[] = L"beta"; 261 const wchar_t kChromeChannelBeta[] = L"beta";
249 const wchar_t kChromeChannelStable[] = L""; 262 const wchar_t kChromeChannelStable[] = L"";
250 263
251 const size_t kMaxAppModelIdLength = 64U; 264 const size_t kMaxAppModelIdLength = 64U;
252 265
253 } // namespace installer 266 } // namespace installer
OLDNEW
« chrome/installer/setup/install_worker.cc ('K') | « chrome/installer/util/util_constants.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698