Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: Source/core/dom/Document.cpp

Issue 1173283002: Move some Element specific code from Node::detach to Element::detach. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/Document.h ('k') | Source/core/dom/Element.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Document.cpp
diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp
index 5de448e994c44c58bd1dff385ebd6ee67c227640..23236439d247cd9daeba88c98ab4487ab6323355 100644
--- a/Source/core/dom/Document.cpp
+++ b/Source/core/dom/Document.cpp
@@ -3345,22 +3345,21 @@ void Document::removeFocusedElementOfSubtree(Node* node, bool amongChildrenOnly)
setFocusedElement(nullptr);
}
-void Document::hoveredNodeDetached(Node* node)
+void Document::hoveredNodeDetached(Element& element)
{
- ASSERT(node);
if (!m_hoverNode)
return;
m_hoverNode->updateDistribution();
- if (node != m_hoverNode && (!m_hoverNode->isTextNode() || node != ComposedTreeTraversal::parent(*m_hoverNode)))
+ if (element != m_hoverNode && (!m_hoverNode->isTextNode() || element != ComposedTreeTraversal::parent(*m_hoverNode)))
return;
- m_hoverNode = ComposedTreeTraversal::parent(*node);
+ m_hoverNode = ComposedTreeTraversal::parent(element);
while (m_hoverNode && !m_hoverNode->layoutObject())
m_hoverNode = ComposedTreeTraversal::parent(*m_hoverNode);
// If the mouse cursor is not visible, do not clear existing
- // hover effects on the ancestors of |node| and do not invoke
+ // hover effects on the ancestors of |element| and do not invoke
// new hover effects on any other element.
if (!page()->isCursorVisible())
return;
@@ -3369,15 +3368,15 @@ void Document::hoveredNodeDetached(Node* node)
frame()->eventHandler().scheduleHoverStateUpdate();
}
-void Document::activeChainNodeDetached(Node* node)
+void Document::activeChainNodeDetached(Element& element)
{
if (!m_activeHoverElement)
return;
- if (node != m_activeHoverElement)
+ if (element != m_activeHoverElement)
return;
- Node* activeNode = ComposedTreeTraversal::parent(*node);
+ Node* activeNode = ComposedTreeTraversal::parent(element);
while (activeNode && activeNode->isElementNode() && !activeNode->layoutObject())
activeNode = ComposedTreeTraversal::parent(*activeNode);
« no previous file with comments | « Source/core/dom/Document.h ('k') | Source/core/dom/Element.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698